Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[베이] Chapter 8. API 응답 통일 & 에러 핸들러 #48

Merged
merged 1 commit into from
Jun 4, 2024
Merged

[베이] Chapter 8. API 응답 통일 & 에러 핸들러 #48

merged 1 commit into from
Jun 4, 2024

Conversation

h-ye-ryoung
Copy link

@h-ye-ryoung h-ye-ryoung commented Jun 3, 2024 •
edited
Loading

#️⃣ 연관된 이슈

#41

✅ 워크북 체크리스트

  • 모든 핵심 키워드 정리를 마쳤나요?
  • 핵심 키워드에 대해 완벽히 이해하셨나요?
  • 이론 학습 이후 직접 실습을 해보는 시간을 가졌나요?
  • 미션을 수행하셨나요?
  • 미션을 기록하셨나요?

✅ 컨벤션 체크리스트

  • 디렉토리 구조 컨벤션을 잘 지켰나요?
  • pr 제목을 컨벤션에 맞게 작성하였나요?
  • pr에 해당되는 이슈를 연결하였나요?
  • 적절한 라벨을 설정하였나요?
  • 스터디원들에게 code review를 요청하기 위해 reviewer를 등록하였나요?
  • 닉네임/main 브랜치의 최신 상태를 반영하고 있는지 확인했나요?

📌 주안점

@h-ye-ryoung h-ye-ryoung added the ✨ Chapter08 챕터 8 label Jun 3, 2024
@h-ye-ryoung h-ye-ryoung self-assigned this Jun 3, 2024
SoulTree-Lovers
SoulTree-Lovers approved these changes Jun 4, 2024
View reviewed changes
Copy link

@SoulTree-Lovers SoulTree-Lovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

키워드를 자세히 잘 작성해주었습니다. 미션과 따로 커밋하면 좋을 것 같아요!

suuu0719
suuu0719 approved these changes Jun 4, 2024
View reviewed changes
Copy link

@suuu0719 suuu0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요!

bflykky
bflykky approved these changes Jun 4, 2024
View reviewed changes
Copy link

@bflykky bflykky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ye-ryoung h-ye-ryoung merged commit e4561a1 into bey/main Jun 4, 2024
@h-ye-ryoung h-ye-ryoung deleted the bey/#41 branch June 4, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suuu0719 suuu0719 suuu0719 approved these changes

@bflykky bflykky bflykky approved these changes

@SoulTree-Lovers SoulTree-Lovers SoulTree-Lovers approved these changes

Assignees

@h-ye-ryoung h-ye-ryoung

Labels
✨ Chapter08 챕터 8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@h-ye-ryoung @SoulTree-Lovers @bflykky @suuu0719