Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[바니] Chapter06_API URL의 설계 & 프로젝트 세팅 #33

Merged
merged 1 commit into from
May 21, 2024
Merged

[바니] Chapter06_API URL의 설계 & 프로젝트 세팅 #33

merged 1 commit into from
May 21, 2024

Conversation

suuu0719
Copy link

@suuu0719 suuu0719 commented May 20, 2024 •
edited
Loading

#️⃣ 연관된 이슈

#31

✅ 워크북 체크리스트

  • 모든 핵심 키워드 정리를 마쳤나요?
  • 핵심 키워드에 대해 완벽히 이해하셨나요?
  • 이론 학습 이후 직접 실습을 해보는 시간을 가졌나요?
  • 미션을 수행하셨나요?
  • 미션을 기록하셨나요?

✅ 컨벤션 체크리스트

  • 디렉토리 구조 컨벤션을 잘 지켰나요?
  • pr 제목을 컨벤션에 맞게 작성하였나요?
  • pr에 해당되는 이슈를 연결하였나요?
  • 적절한 라벨을 설정하였나요?
  • 스터디원들에게 code review를 요청하기 위해 reviewer를 등록하였나요?
  • 닉네임/main 브랜치의 최신 상태를 반영하고 있는지 확인했나요?

📌 주안점

@suuu0719 suuu0719 added the ✨ Chapter06 챕터 6 label May 20, 2024
@suuu0719 suuu0719 self-assigned this May 20, 2024
bflykky
bflykky approved these changes May 21, 2024
View reviewed changes
Copy link

@bflykky bflykky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 현재 진행한 미션 목록을 조회할 때 Query String에 1개의 key status에 2개의 value를 설정함으로써 해당 API의 역할을 명시적으로 잘 나타냈어요.

SoulTree-Lovers
SoulTree-Lovers approved these changes May 21, 2024
View reviewed changes
Copy link

@SoulTree-Lovers SoulTree-Lovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마크다운으로 자세히 잘 작성해준 것 같습니다!

@h-ye-ryoung
Copy link

LGTM깔끔해요!!

@suuu0719 suuu0719 merged commit d7c2e1e into bany/main May 21, 2024
@suuu0719 suuu0719 deleted the bany/#31 branch May 21, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-ye-ryoung h-ye-ryoung h-ye-ryoung approved these changes

@bflykky bflykky bflykky approved these changes

@SoulTree-Lovers SoulTree-Lovers SoulTree-Lovers approved these changes

Assignees

@suuu0719 suuu0719

Labels
✨ Chapter06 챕터 6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suuu0719 @h-ye-ryoung @SoulTree-Lovers @bflykky