Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt nyan to new specification #84
Adapt nyan to new specification #84
Changes from 1 commit
ef6cf3b
ec687e0
e017655
05f74f6
1083219
d075d25
c9a9daa
d2a9005
e29f7d4
8e902ec
0b873cf
096317c
c1b62b5
32df34b
6b19fab
6902201
4b005dd
80ea0e9
f4000a4
5995d04
4497163
5090faf
28465f5
436071b
2eee390
6d02965
1af9713
f1a190e
fee9488
78cd996
aeeaa1b
d1c52d9
9c2a7fe
06212ba
ecbb66f
ef2bf3a
458bb5e
9a4c8ab
6358d0e
36af270
312914b
6756dc1
d139bab
a54937e
bf5db02
4025fff
5ed8e63
d48c873
a345388
492d730
c6e080a
0f79321
9122237
543478d
8ba7e7a
549855c
ba2cdfc
7d5dfaa
22b1725
8fd9b9e
ccae9c0
bb3dfd4
1a092e3
90097df
3cb82d7
590c268
2831c7e
a83907e
8e537c9
b8952bf
72f5e03
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the python standard is to always use
repr
for the dict members. soDict::str
andDict::repr
can be identicall, and use therepr
variant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so just use
return this->repr();
in this function?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, i'd say so.