Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Automated tests for current chats filter #33556

Draft
wants to merge 2 commits into
base: feat/single-contact-id
Choose a base branch
from

Conversation

Harmeet221
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@Harmeet221 Harmeet221 requested review from a team as code owners October 13, 2024 12:34
Copy link
Contributor

dionisio-bot bot commented Oct 13, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 13, 2024

⚠️ No Changeset found

Latest commit: 5e329ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Harmeet221 Harmeet221 marked this pull request as draft October 13, 2024 12:36
Copy link
Contributor

github-actions bot commented Oct 13, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33556/
on branch gh-pages at 2024-10-18 11:30 UTC

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.35%. Comparing base (5e98135) to head (5e24c65).
Report is 53 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feat/single-contact-id   #33556      +/-   ##
==========================================================
- Coverage                   58.43%   58.35%   -0.09%     
==========================================================
  Files                        2744     2746       +2     
  Lines                       66280    66366      +86     
  Branches                    15001    15013      +12     
==========================================================
- Hits                        38732    38727       -5     
- Misses                      24717    24805      +88     
- Partials                     2831     2834       +3     
Flag Coverage Δ
unit 74.15% <ø> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris changed the base branch from develop to feat/single-contact-id October 14, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant