-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move Enhanced navigation
out of feature preview
#33529
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Enhanced navigation
Enhanced navigation
out of feature preview
a89f4a9
to
ec79a1d
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33529 +/- ##
===========================================
- Coverage 58.59% 58.40% -0.20%
===========================================
Files 2739 2744 +5
Lines 65696 66168 +472
Branches 14826 14961 +135
===========================================
+ Hits 38496 38643 +147
- Misses 24420 24714 +294
- Partials 2780 2811 +31
Flags with carried forward coverage won't be shown. Click here to find out more. |
8742628
to
3209752
Compare
…m/HeaderV2` to `client/views/room/Header`
3209752
to
355f259
Compare
Proposed changes (including videos or screenshots)
Enhanced navigation
away from feature preview and make it official SIDE-210Header
NavBar
sidebar
Issue(s)
Steps to test or reproduce
Further comments