feat: add a new HrFlowTrackingWarehouse to the HrFlow Connector #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-forest-tree
requested changes
Apr 18, 2024
poetry.lock
Outdated
There was a problem hiding this comment.
Pour l'instant on update pas les versions des dependances. Par le passé ca a crée parfois des soucis au moment de mettre à jour customers.
Donc aucun changement dans ce fichier n'est attendu pour cette PR
There was a problem hiding this comment.
cela doit être dû au refactoring du sdk hrflow ( storing, searching, asking etc) alors que dans le code de hrflow-connectors (profile.py, job.py) on utilise l'ancienne structure( indexing etc).
There was a problem hiding this comment.
Mais vu que le Tracking n'a été ajouté que dans la nouvelle version et qu'il utilise la nouvelle structure, nous devons mettre à jour les dépendances pour qu'il soit fonctionnel, non ?
PR review cahnges
nedhirouebnou
force-pushed
the
feature/add-new-warehouses-to-hrflow-connector
branch
from
b3c4c0c to
7659919
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.