Remove Microsoft.Extensions.PlatformAbstractions #5058
+4
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saibamen
reviewed
Nov 26, 2024
Comment on lines
16
to
17
| <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="8.0.0" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="8.0.0" /> |
There was a problem hiding this comment.
Suggested change
| <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="8.0.0" /> | |
| <PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="8.0.0" /> | |
| <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="8.0.11" /> | |
| <PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="8.0.11" /> |
There was a problem hiding this comment.
Latest is not always greatest, I've chosen lowest version possible.without problems to minimize effects on consumers.
Saibamen
reviewed
Nov 26, 2024
| @@ -14,12 +14,10 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'"> | |||
| <PackageReference Include="Microsoft.Extensions.DependencyModel" Version="8.0.0" /> | |||
| <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="8.0.0" /> | |||
There was a problem hiding this comment.
Suggested change
| <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="8.0.0" /> | |
| <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="8.0.11" /> |
* fix some vulnerable dependencies
lahma
force-pushed
the
remove-platform-abstractions
branch
from
17cbd11
to
fcbd987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to remediate some problems with dependencies with incremental update.
Microsoft.Extensions.PlatformAbstractionshas been deprecated and there are APIs to use without that. OldMoqbrings some vulnerable dependencies with it.I tested this with debugger and both
net462(Console) and core versions (8 and 9, ConsoleCore) seemed to hit the correct breakpoints/paths.