Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show DisplayName for conflicting actions #5057

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Saibamen
Copy link
Contributor

@Saibamen Saibamen commented Nov 26, 2024

Just like in Swashbuckle (https://github.com/domaindrivendev/Swashbuckle.AspNetCore/blob/master/src/Swashbuckle.AspNetCore.SwaggerGen/SwaggerGenerator/SwaggerGenerator.cs#L290).

Reduce some code differences between AspNetCore and NSwag.Generation.WebApi projects.

Before

image

After

image

@Saibamen Saibamen marked this pull request as draft November 26, 2024 15:03
@Saibamen Saibamen marked this pull request as ready for review November 26, 2024 15:12
@Saibamen
Copy link
Contributor Author

And for ASP.NET Framework:

image

@lahma
Copy link
Collaborator

lahma commented Nov 26, 2024

Are you sure the PR scope is still according to the title?

@Saibamen
Copy link
Contributor Author

Yes. I added NSwag.Sample.AspNet project, because in this repository we have only .NET >= 8 sample projects

@Saibamen
Copy link
Contributor Author

OK, forget about NSwag.Sample.AspNet... I don't have time to fight with build errors about "missing nuget package" for old .NET Framework build solutions in GitHub Actions generated with Nuke.

@Saibamen
Copy link
Contributor Author

Saibamen commented Nov 26, 2024

Rerun GH Actions to "fix" flaky tests in master branch...

GitHub Actions / ubuntu-latest
NSwag.ConsoleCore.Tests.GenerateSampleSpecificationTests.Should_generate_openapi_for_project(projectName: "NSwag.Sample.NET90Minimal"

System.InvalidOperationException : Process must exit before requested information can be determined.

@Saibamen Saibamen closed this Nov 26, 2024
@Saibamen Saibamen reopened this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants