Case sensitive parameter name matching for path parameters #4992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es on a case insensitive basis. Otherwise some parameters won't match if the schema isn't 100% correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scanning parameter list for path parameters, match parameter names on a case insensitive basis. Otherwise some parameters won't match if the schema isn't 100% correct
I had an openapi operation with path "/api/ocrforms/{formid}/active" but the parameter collection had name "formId". This was from a third party API that I didn't create.
Nswag either needs to work in case insensitive mode or inject "TODO" or some exception code to make it obvious when path segments don't match parameter names for a given operation.