Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Node.js to devcontainer and reduce size #3

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

falsepopsky
Copy link
Collaborator

  • feat: added Node.js
  • chore: to improve readability and prevent conflicts with potentially added options, the configuration was moved from the devcontainer.json file to the .vscode folder.
  • fix: the latest configuration contains duplicated code (repo) in folders:
    • workspaces
    • workspace

workspce

with the new update we just work in workspaces

fix

for some reason the commnds in the dockerfile doesn't work with the new config, probably because the context path, so for now i just moved the installation in postCreateCommand

@falsepopsky
Copy link
Collaborator Author

i need to check that labeler workflow the config it's okay but doesn't work on forked repos in the new version (interesting !), also:
actions/labeler#755

@falsepopsky falsepopsky merged commit 533d0f4 into RetroOlympics:main Jun 21, 2024
1 check passed
@falsepopsky falsepopsky deleted the dev branch June 21, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant