Merge pull request #430 from yarikoptic/enh-do-not-set-cmp=False

RF: revert to default cmp=True for attr.s. Rely on frozen to get hash generated
ReproNim · Jun 19, 2019 · c291a61 · c291a61
2 parents fe6f7f9 + fae7a7e
commit c291a61
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/reproman/distributions/debian.py b/reproman/distributions/debian.py
@@ -51,8 +51,8 @@
 
 # TODO: flyweight/singleton ?
 # To make them hashable we need to freeze them... not sure if we are ready:
-#@attr.s(cmp=True, hash=True, frozen=True)
-@attr.s(cmp=True)
+#@attr.s(cmp=True, frozen=True)
+@attr.s
 class APTSource(SpecObject):
     """APT origin information
     """
@@ -69,7 +69,7 @@ class APTSource(SpecObject):
 _register_with_representer(APTSource)
 
 
-@attr.s(slots=True, frozen=True, cmp=False, hash=True)
+@attr.s(slots=True, frozen=True)
 class DEBPackage(Package):
     """Debian package information"""
     name = attrib(default=attr.NOTHING)

diff --git a/reproman/distributions/docker.py b/reproman/distributions/docker.py
@@ -23,7 +23,7 @@
 from ..utils import attrib
 
 
-@attr.s(slots=True, frozen=True, cmp=False, hash=True)
+@attr.s(slots=True, frozen=True)
 class DockerImage(Package):
     """Docker image information"""
     id = attrib(default=attr.NOTHING)

diff --git a/reproman/distributions/redhat.py b/reproman/distributions/redhat.py
@@ -45,7 +45,7 @@ class RPMSource(SpecObject):
 _register_with_representer(RPMSource)
 
 
-@attr.s(slots=True, frozen=True, cmp=False, hash=True)
+@attr.s(slots=True, frozen=True)
 class RPMPackage(Package):
     """Redhat package information"""
     name = attrib(default=attr.NOTHING)

diff --git a/reproman/distributions/singularity.py b/reproman/distributions/singularity.py
@@ -26,7 +26,7 @@
 from ..utils import attrib, md5sum, chpwd
 
 
-@attr.s(slots=True, frozen=True, cmp=False, hash=True)
+@attr.s(slots=True, frozen=True)
 class SingularityImage(Package):
     """Singularity image information"""
     md5 = attrib(default=attr.NOTHING)