Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rxjs.dev): add api list deprecated filter #7383

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

daniel-melanson
Copy link

Description:

Adds a "Show deprecated" checkbox to optionally filter out deprecated items.

BREAKING CHANGE: N/A

Related issue (if exists): N/A

@daniel-melanson daniel-melanson changed the title Filter deprecated feat(rxjs.dev): add api list deprecated filter Nov 21, 2023
@benlesh
Copy link
Member

benlesh commented Nov 28, 2023

This a cool idea. @niklas-wortmann or @jakovljevic-mladen can you please have a look?

Copy link
Member

@jakovljevic-mladen jakovljevic-mladen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @daniel-melanson, thank you a lot for this PR, it looks really cool and I think we should definitely have such option. However, we had it before, but it was for some reason removed and it was never restored back.

The original version had a dropdown select option, but that option was commented for some reason in the template. All other functionality around that option remained in the code (and probably in the tests). This commented code has been removed in #6936.

I would strongly suggest we go in that direction because dropdown select option is capable of having more options than we could have with a checkbox. Could you please review the code removed from the mentioned PR and try to include it in the current code base?

The code I'm referring to looked like this:

<!-- <aio-select (change)="setStatus($event.option)"
  [options]="statuses"
  [selected]="status"
  label="Status:">
</aio-select> -->

And instead of having status (in the statuses array in the component class):

{ value: 'security-risk', title: 'Security Risk' }

we could have:

{ value: 'stable', title: 'Stable' }

Because we probably won't ever introduce potentially dangerous code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants