Skip to content

Commit

Permalink
Fix typos introduced recently
Browse files Browse the repository at this point in the history
Signed-off-by: Nir Soffer <[email protected]>
  • Loading branch information
nirs authored and ShyamsundarR committed Nov 27, 2024
1 parent 2ed6b0b commit 6c96132
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions internal/controller/vrg_volrep.go
Original file line number Diff line number Diff line change
Expand Up @@ -1327,7 +1327,7 @@ func (v *VRGInstance) selectVolumeReplicationClass(
}

// if peerClasses does not exist, replicationClasses would not have SID in
// older ramen versions, this check is neeed because we need to handle upgrade
// older ramen versions, this check is needed because we need to handle upgrade
// scenario where SID is not present in replicatioClass.

// if peerClass exist, continue to check if SID matches, or skip the check and proceed
Expand Down Expand Up @@ -1553,7 +1553,7 @@ func (v *VRGInstance) validateVRValidatedStatus(

// validateVRCompletedStatus validates if the VolumeReplication resource Completed condition is met and update
// the PVC DataReady and Protected conditions.
// Returns true if the condtion is true, false if the condition is missing, stale, ubnknown, of false.
// Returns true if the condition is true, false if the condition is missing, stale, ubnknown, of false.
func (v *VRGInstance) validateVRCompletedStatus(pvc *corev1.PersistentVolumeClaim, volRep *volrep.VolumeReplication,
state ramendrv1alpha1.ReplicationState,
) bool {
Expand Down Expand Up @@ -2405,7 +2405,7 @@ func (v *VRGInstance) processPVSecrets(pv *corev1.PersistentVolume) error {
pv.Spec.CSI.ControllerExpandSecretRef = secFromSC
}

// the value for provisionerSecretName and provisionerDeletionSecretName are allways same. so we check
// the value for provisionerSecretName and provisionerDeletionSecretName are always same. so we check
// if provisionerSecretName name exists in storageClass and if exists we populate PV Annotation with
// provisionerDeletionSecretName with the values from provisionerSecretName and its namespace values.
secFromSC, exists = secretsFromSC(sc.Parameters, provisionerSecretName, provisionerSecretNamespace)
Expand Down
6 changes: 3 additions & 3 deletions internal/controller/vrg_volrep_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ var _ = Describe("VolumeReplicationGroupVolRepController", func() {

// Test VRG finalizer removal during deletion is deferred till VR is deleted
var vrgVRDeleteEnsureTestCase *vrgTest
Context("in primary state where VRG finalizer removal is deferred duing deletion", func() {
Context("in primary state where VRG finalizer removal is deferred during deletion", func() {
storageIDLabel := genStorageIDLabel(storageIDs[0])
storageID := storageIDLabel[vrgController.StorageIDLabel]
vrcLabels := genVRCLabels(replicationIDs[0], storageID, "ramen")
Expand Down Expand Up @@ -1433,7 +1433,7 @@ var _ = Describe("VolumeReplicationGroupVolRepController", func() {
vrcProvisioner: "manual.storage.com",
scProvisioner: "manual.storage.com",
}
Context("Basic test with no peerClassses", func() {
Context("Basic test with no peerClasses", func() {
It("sets up PVCs, PVs and VRGs", func() {
vrgNoPeerClassesTemplate.s3Profiles = []string{s3Profiles[vrgS3ProfileNumber].S3ProfileName}
storageIDLabel := genStorageIDLabel(storageIDs[0])
Expand Down Expand Up @@ -1470,7 +1470,7 @@ var _ = Describe("VolumeReplicationGroupVolRepController", func() {
vrcProvisioner: "manual.storage.com",
scProvisioner: "manual.storage.com",
}
Context("Basic test with no peerClassses with replicationID in vrc", func() {
Context("Basic test with no peerClasses with replicationID in vrc", func() {
It("sets up PVCs, PVs and VRGs", func() {
vrgNoPeerClassesAndReplicationIDTemplate.s3Profiles = []string{s3Profiles[vrgS3ProfileNumber].S3ProfileName}
storageIDLabel := genStorageIDLabel(storageIDs[0])
Expand Down

0 comments on commit 6c96132

Please sign in to comment.