ODC-114 Support groupBy=NA and CollapseDataForGating = FALSE #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ique sampleNames().
|
@amcdavid are you seeing any failed tests for this PR? I recall seeing something internally but everything seems fine here. |
|
This one fails internal tests: https://github.com/OzetteTech/mono-repo/actions/runs/11710644588/job/32617389563?pr=4117 |
|
Hmmm... that test fails at the kmeans step because there are too few events in the sample. The gatingTemplate has groupBy = NA and collapseDataForGating = NA so I don't think the proposed change is the cause of that error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amcdavid adding PR here to implement features or fixes required by CytoExploreR please see https://ozette.atlassian.net/browse/ODC-114.
I have implemented the same fix that I used for the internal version of openCyto here: https://github.com/OzetteTech/mono-repo/pull/4117/commits/987908151ed6253a00dd438ba0e1c73062f89777
I just need to check that failing test - I don't think it is anything we need to be worried about. I think that test just needs updating then we can merge to both versions of openCyto.