Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-182 Support logical and factor CytoExploreR's clustering #260

Draft
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

djhammill
Copy link
Contributor

@amcdavid adding PR here to implement features or fixes required by CytoExploreR please see https://ozette.atlassian.net/browse/ODC-182

NOTE: This is draft PR it is known to causes issues for some edge cases, I will investigate a better solution and update this PR.

@djhammill djhammill marked this pull request as draft November 5, 2024 04:38
@djhammill djhammill requested a review from amcdavid November 5, 2024 04:38
@djhammill djhammill self-assigned this Nov 5, 2024
@djhammill
Copy link
Contributor Author

I am thinking that maybe we should only invoke the new code if the gating function is cyto_gate_clust() - that will ensure that everything behaves normally within openCyto and CytoExploreR.

@djhammill
Copy link
Contributor Author

Alternatively we separate out filter and filters objects from logical and factor and treat those separately. It doesn't make sense to replicate event-wise logical or factor filters across multiple samples where the event number may be different. I will try converting the gates within CytoExploreR to be either logical or factor to see if I can get it to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant