-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display each drive filebrowser in a separate side panel #10
Open
HaudinFlorence
wants to merge
21
commits into
QuantStack:main
Choose a base branch
from
HaudinFlorence:display_each_drive_browser_in_a_separate_panel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Display each drive filebrowser in a separate side panel #10
HaudinFlorence
wants to merge
21
commits into
QuantStack:main
from
HaudinFlorence:display_each_drive_browser_in_a_separate_panel
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaudinFlorence
force-pushed
the
display_each_drive_browser_in_a_separate_panel
branch
from
December 5, 2023 17:15
f3d3f5a
to
0076f6c
Compare
HaudinFlorence
force-pushed
the
display_each_drive_browser_in_a_separate_panel
branch
8 times, most recently
from
December 11, 2023 23:23
0b46de9
to
e41a9c0
Compare
HaudinFlorence
force-pushed
the
display_each_drive_browser_in_a_separate_panel
branch
7 times, most recently
from
December 18, 2023 21:39
dc05040
to
1e13fbe
Compare
HaudinFlorence
force-pushed
the
display_each_drive_browser_in_a_separate_panel
branch
2 times, most recently
from
December 21, 2023 14:53
b6fd1fc
to
d2124b1
Compare
HaudinFlorence
force-pushed
the
display_each_drive_browser_in_a_separate_panel
branch
from
January 16, 2024 14:15
f29a42f
to
ca36cbd
Compare
…with the default file browser and the added drive one.
…ddDrivesPlugin and moved hard coded inputs mimicking backend side inputs , outside from the plugins and methods.
Add logics to add the content of the drive to the filebrowser when adding a drive in the dialog.
…nterface, when picking a drive by its name in the list of available drives. Add a toolbar to all the drive filebrowsers.
Create a BreadCrumbsLayout to enable to have the breadcrumbs inside the AccordionPanel title section
…multidrivesbrowser.ts, dirlisting.ts -> drivelisting.ts. Restore in index.ts a proper logics to add the content of an added driveBrowser to the multidrives browser when a drive is selected and added in the dialog.
…multidrivesbrowser.ts, dirlisting.ts -> drivelisting.ts. Restore in index.ts a proper logics to add the content of an added driveBrowser to the multidrives browser when a drive is selected and added in the dialog.
…d remove non unnecessary files.
…panel containing a drive filebrowser.
…depanel and its respective drive filebrowser.
… the informations about the list of drives and create the corresponding new Drive instances with faked contents at this stage.
HaudinFlorence
force-pushed
the
display_each_drive_browser_in_a_separate_panel
branch
from
January 16, 2024 14:16
ca36cbd
to
d22b5ee
Compare
HaudinFlorence
force-pushed
the
display_each_drive_browser_in_a_separate_panel
branch
from
January 16, 2024 15:02
d22b5ee
to
a90e0bb
Compare
…nd update index.ts and drivelistmanager to be able to add and remove panels containing drive filebrowsers for drives selected in the dialog.
HaudinFlorence
force-pushed
the
display_each_drive_browser_in_a_separate_panel
branch
from
January 17, 2024 16:17
a90e0bb
to
106e5b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements:
Screencast.from.16-01-2024.15.23.42.webm
cc : @afshin, @jtpio