Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display each drive filebrowser in a separate side panel #10

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

HaudinFlorence
Copy link
Member

@HaudinFlorence HaudinFlorence commented Dec 5, 2023

This PR implements:

  • a command accessible from the command Palette with label "Add a New Drive Filebrowser" that opens a dialog listing all the available drives (the available S3 buckets are listed in the backend, but here fake buckets with fake content are used instead of using a get request).
  • in the dialog, by clicking on add drive buttons the user can add a new drive in the table displayed on the right, if the status of this drive is active. If not, a warning is sent. At the same time, a new left sidepanel is added, containing the filebrowser of the drive that has just been added.
  • By using the contextual menu (right click on the "D" drive icons in the sidepanel), it is possible to remove a filebrowser and dispose the drive, using the command labelled as "Remove Drive File Browser". It uses a logics based on retrieving the id of the panel when the user click on its respective button in the left sidebar.
  • The logics related to the update of the selected drives is made mainly in driveListManager.tsx, by the specific react components and a VDOMModel that is update at any change.
Screencast.from.16-01-2024.15.23.42.webm

cc : @afshin, @jtpio

Copy link

github-actions bot commented Dec 5, 2023

Binder 👈 Launch a Binder on branch HaudinFlorence/jupyter-drives/display_each_drive_browser_in_a_separate_panel

@HaudinFlorence HaudinFlorence force-pushed the display_each_drive_browser_in_a_separate_panel branch from f3d3f5a to 0076f6c Compare December 5, 2023 17:15
@HaudinFlorence HaudinFlorence added the enhancement New feature or request label Dec 5, 2023
@HaudinFlorence HaudinFlorence force-pushed the display_each_drive_browser_in_a_separate_panel branch 8 times, most recently from 0b46de9 to e41a9c0 Compare December 11, 2023 23:23
@HaudinFlorence HaudinFlorence force-pushed the display_each_drive_browser_in_a_separate_panel branch 7 times, most recently from dc05040 to 1e13fbe Compare December 18, 2023 21:39
@HaudinFlorence HaudinFlorence force-pushed the display_each_drive_browser_in_a_separate_panel branch 2 times, most recently from b6fd1fc to d2124b1 Compare December 21, 2023 14:53
@HaudinFlorence HaudinFlorence force-pushed the display_each_drive_browser_in_a_separate_panel branch from f29a42f to ca36cbd Compare January 16, 2024 14:15
…with the default file browser and the added drive one.
…ddDrivesPlugin and moved hard coded inputs mimicking backend side inputs , outside from the plugins and methods.
Add logics to add the content of the drive to the filebrowser when adding a drive in the dialog.
…nterface, when picking a drive by its name in the list of available drives.

Add a toolbar to all the drive filebrowsers.
Create a BreadCrumbsLayout to enable to have the breadcrumbs inside the AccordionPanel title section
…multidrivesbrowser.ts, dirlisting.ts -> drivelisting.ts. Restore in index.ts a proper logics to add the content of an added driveBrowser to the multidrives browser when a drive is selected and added in the dialog.
…multidrivesbrowser.ts, dirlisting.ts -> drivelisting.ts. Restore in index.ts a proper logics to add the content of an added driveBrowser to the multidrives browser when a drive is selected and added in the dialog.
@HaudinFlorence HaudinFlorence force-pushed the display_each_drive_browser_in_a_separate_panel branch from ca36cbd to d22b5ee Compare January 16, 2024 14:16
@HaudinFlorence HaudinFlorence self-assigned this Jan 16, 2024
@HaudinFlorence HaudinFlorence force-pushed the display_each_drive_browser_in_a_separate_panel branch from d22b5ee to a90e0bb Compare January 16, 2024 15:02
…nd update index.ts and drivelistmanager to be able to add and remove panels containing drive filebrowsers for drives selected in the dialog.
@HaudinFlorence HaudinFlorence force-pushed the display_each_drive_browser_in_a_separate_panel branch from a90e0bb to 106e5b8 Compare January 17, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant