-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new get_control_flow_name_mapping
function
#13472
base: main
Are you sure you want to change the base?
Conversation
…te_preset_pass_manager and add reno.
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 11976548054Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
The way this is implemented matches how it has been used so I think it is good. One point that we should note at least is that the standard gate version of this function returns a mapping to gate instances while the control flow function here returns a mapping to classes. The gates version gets away with this by using By the way, you can also replace this case: qiskit/qiskit/providers/backend_compat.py Lines 94 to 99 in 5f3f594
|
Thanks @wshanks! I applied your suggestion in 5434583. you're right, the function doesn't match the gate version exactly, but I also didn't find any reasonable way to instantiate the gates, and tried to avoid making the parallelism in the docs for that reason. There is a risk that users might still associate them but well... we could always highlight the difference in documentation if necessary. |
Summary
Addresses #13468 by exposing the mapping done in
generate_preset_pass_manager
as a public function for convenience.Details and comments