2024 04 24 fix swmm views #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SWMM 5.1. seems not to like NULL values in these colums and throws an error
|
Documentation update: see QGEP/docs#224 |
|
@ponceta Do I need to make a full delta? |
|
@ponceta What is going wrong here? |
ponceta
reviewed
Aug 22, 2024
| NULL as StageData, | ||
| -- 'FREE'::varchar as Type, | ||
| CASE | ||
| WHEN waterlevel_hydraulic IS NOT NULL THEN 'FIXED' |
There was a problem hiding this comment.
Looks like this attribute is only available in discharge points in this model
waterlevel_hydraulic
It would be better to be explicit like dp.waterlevel_hydraulic to avoid missing joins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWMM 5.1 / 5.2. seems not to like NULL values if there is no data - therefore replacing defaults with 0 resp. 0.0 instead.