-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PyPy3.11 #4760
base: main
Are you sure you want to change the base?
Add PyPy3.11 #4760
Conversation
Hmm. There is a unused declaration error. Any suggestions how to fix that?
|
These occur because with this there are new In the order from the error above, I think these should be 🤞:
|
Thanks, let's try it |
Yup, that seems to have done the trick. Is there anything else I should try? I will mark this as "draft" since it can wait for the release to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I added a label so that the full CI will trigger if you push again to this branch. This should execute more PyPy3.11 jobs and give better feedback.
Aside, if pypy/pypy#3836 ever gets resolved it will vastly increase the amount of testing of PyPy we can do here, because we have an absolute heap of tests which use Py_Initialize
to spawn interpreters and run basic checks. I think it's out of scope for me to find time to work on that for the foreseeable future sadly.
@@ -242,8 +242,8 @@ jobs: | |||
"3.11", | |||
"3.12", | |||
"3.13", | |||
"pypy3.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Historically we've been slow to drop support of PyPy versions (typically we match the version of CPython EOL just to keep things simpler). Do you think it's better if we drop PyPy versions eagerly on EOL? Would certainly mean fewer CI runs 😂
Also, if we want to drop PyPy 3.9 support, I would rather we removed the CI jobs, started preventing compiles (because it's possible we might break it by accident once CI is removed), and added a newsfragment to announce, all in one step. Probably best to split into a separate PR, if we want to do this now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's better if we drop PyPy versions eagerly on EOL?
It is up to you. I don't think we would do another 3.9 release even if a new issue were discovered. I would try to help you solve them though not with a high priority. Have you had many PyPy-specific issues reported? I will revert this change and let you do it at your tempo.
newsfragments/4760.added.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename this to 4760.packaging.md
- we put the packaging section at the top so easier for users to notice this.
Unfortunately we are also unlikely to implement |
Support PyPy's python3.11. It is not officially released yet, but I wanted to be sure PyO3 works.
I am testing this branch elsewhere. Until there is an official release, I set the PR to use the nightly builds.
You may wish to hold off on merging this until the official release, that is fine with me.
Also I dropped PyPy3.9 since we no longer support it. Nothing has changed so it should JustWork(tm)
I had help from the discussions, thanks!