update complexobject.rs for 3.13
#4521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
reviewed
Sep 3, 2024
| #[cfg(not(GraalPy))] | ||
| pub cval: Py_complex, | ||
| } | ||
|
|
There was a problem hiding this comment.
Out of curiosity, do you care about exposing these structs in the same locations as the C API does in all python versions? cpython/complexobject.h first appeared in 3.11 so these definitions are correct on 3.10 and older.
There was a problem hiding this comment.
Generally I try to keep the locations matching latest CPython we support, to make reconciliation against the headers more straightforward.
If a symbol just didn't exist at all on older python versions then we can cfg it out.
I think having cfg-d implementations at different locations just makes the overall complexity a bit higher.
Of course, I don't think we've been perfect at following this exact strategy (and often lag CPython a bit).
ngoldbaum
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #4379
This updates
complexobject.rsfor 3.13 structure, and removes the definitions of the private symbols at the same time.