Skip to content
This repository has been archived by the owner on May 15, 2018. It is now read-only.

Modifying Enable-DscEventLog to be exportable #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ArtWDrahn
Copy link
Contributor

Breaking up my commits into seperate PRs without any white space changes. Should be easier to review. 👍

@dlwyatt
Copy link
Member

dlwyatt commented Oct 21, 2014

There are a couple of problems here. There's a call to Enable-DscEventLog elsewhere in the code (from Test-DscEventLogStatus) that you need to update as well, since Enable-DscEventLog now uses parameters instead of looking up the value of Script variables.

Also, there's still a bit of code inside the new Enable-DscEventLog which is looking at $script:ThisCredential instead of the new $Credential parameter.

@dlwyatt
Copy link
Member

dlwyatt commented Oct 21, 2014

Looks like the first issue might be covered in your other PR, though; I'll look at that next.

@ArtWDrahn
Copy link
Contributor Author

I fixed the bug where I wasn't checking for $Credentials, thanks for the catch!

@vors
Copy link

vors commented Oct 22, 2014

@ArtWDrahn 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants