chore: Remove CurseForge API key from env variables and put it in the…

… constants file
Polyfrost · Nov 28, 2024 · fc834bb · fc834bb
1 parent cbc7ae8
commit fc834bb
Show file tree

Hide file tree

Showing 9 changed files with 3 additions and 240 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -38,7 +38,6 @@ jobs:
       - uses: tauri-apps/tauri-action@v0
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          CURSEFORGE_API_KEY: ${{ secrets.CURSEFORGE_API_KEY }}
         with:
           tagName: onelauncher-__VERSION__
           releaseName: OneLauncher __VERSION__

diff --git a/.template.env b/.template.env
diff --git a/apps/frontend/tsconfig.json b/apps/frontend/tsconfig.json
diff --git a/apps/frontend/tsconfig.node.json b/apps/frontend/tsconfig.node.json
diff --git a/apps/frontend/uno.config.ts b/apps/frontend/uno.config.ts
diff --git a/apps/frontend/vitest.config.ts b/apps/frontend/vitest.config.ts
diff --git a/packages/core/build.rs b/packages/core/build.rs
diff --git a/packages/core/src/api/package/content/curseforge.rs b/packages/core/src/api/package/content/curseforge.rs
@@ -450,8 +450,7 @@ pub async fn fetch_advanced<F: FnOnce(&mut Url)>(
 	json_body: Option<serde_json::Value>,
 ) -> Result<Bytes> {
 	// TODO: Get the API key from settings, fallback to constant, and error if missing
-	let key = crate::constants::CURSEFORGE_API_KEY
-		.ok_or(anyhow::anyhow!("missing curseforge api key"))?;
+	let key = crate::constants::CURSEFORGE_API_KEY;
 
 	let mut headers = headers.unwrap_or(HashMap::<&str, &str>::new());
 	headers.insert("x-api-key", key);

diff --git a/packages/core/src/constants.rs b/packages/core/src/constants.rs
@@ -38,8 +38,8 @@ pub const MODRINTH_API_URL: &str = "https://api.modrinth.com/v2";
 pub const MODRINTH_V3_API_URL: &str = "https://api.modrinth.com/v3";
 /// The Curseforge API base url.
 pub const CURSEFORGE_API_URL: &str = "https://api.curseforge.com";
-/// The Curseforge API key. This is a secret and should not be shared.
-pub const CURSEFORGE_API_KEY: Option<&'static str> = option_env!("CURSEFORGE_API_KEY");
+/// The Curseforge API key. Reserved for use in OneLauncher projects only. Do not use in other projects without permission from the OneLauncher team.
+pub const CURSEFORGE_API_KEY: &str = "$2a$10$6utA1UNSmFPrE/Lh7b7ndeeGmiOkjKNY8kpFB0fsmE/d42ZAfFgCe";
 /// The Minecraft game ID on Curseforge.
 pub const CURSEFORGE_GAME_ID: u32 = 432;
 /// Our metadata API base url.