Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Build Artifacts #49

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

gabrielvicenteYT
Copy link

Description

This pull request allows users to have the latest commit's build.

Release Notes

  • Add build artifacts

Documentation

Does this PR require updates to the documentation at docs.polyfrost.cc?

  • No

.gitignore Outdated Show resolved Hide resolved
@gabrielvicenteYT
Copy link
Author

@Wyvest Done

Copy link
Member

@nextdayy nextdayy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pauliesnug
Copy link
Member

but why? this literally makes no difference other then uploaded build artifacts which are unnecessary

Copy link
Member

@xtrm-en xtrm-en left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nightly user builds are pog

Copy link
Member

@pauliesnug pauliesnug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other then this


on:
push:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change this lol ?


concurrency:
# Maximum of one running workflow per pull request source branch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove these comments?


- uses: gradle/wrapper-validation-action@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gradle wrapper validation is important


- uses: actions/setup-java@v2
- name: Set up JDK 17
uses: actions/setup-java@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should bump all actions deps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants