Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont show 1 #26

Open
wants to merge 9 commits into
base: oneconfig
Choose a base branch
from
Open

Conversation

Waffles3438
Copy link

Description

made it not show items when item stack is 1, such as a sword

Related Issue(s)

Fixes #

How to test

Release Notes

Documentation

@Waffles3438 Waffles3438 changed the title made it so not showing 1 Jul 5, 2024
@Waffles3438 Waffles3438 changed the title not showing 1 dont show 1 Jul 5, 2024
@MicrocontrollersDev
Copy link
Contributor

This approach is inefficient and annoying to constantly maintain. I have done no testing but it seems like it would be easier to check if stack.getMaxStackSize() is 1 instead of checking what the item is. If this doesn't work, vanilla should do something similar for how it displays in inventories/containers.

@Waffles3438
Copy link
Author

This approach is inefficient and annoying to constantly maintain. I have done no testing but it seems like it would be easier to check if stack.getMaxStackSize() is 1 instead of checking what the item is. If this doesn't work, vanilla should do something similar for how it displays in inventories/containers.

this makes it so you can tell how many of each potion you have in your inventory though

@MicrocontrollersDev
Copy link
Contributor

you mean current upstream implementation? then just check if itemStack is of PotionItem and don't do it then. there's less special items like this than there are single stack items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants