Fixed Chat Peek warning with SkyHanni #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might want to include the tutorial on how to open the settings for both mods in the popup warning, not sure |
|
"break the other mod on purpose so users use my mod" doesn't sound like a strategy for community projects |
|
|
The rest of the mixins i can confirm were because of conflicts with chatting and the other mod’s features. i think what might’ve happened is someone saw those notifications but noticed it didn’t happen for skyhanni chat peek, and then reported it to us and we “fixed” it. however i think there’s also a chance that there is actually a conflict with chatting and skyhanni chat peek so someone should test that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the Chatting mod warns the user if they are using SkyHanni's chat peek feature active and have disabled the feature in Chatting. This indicates that this behavior is not intended without giving the user the choice to use either feature.
This PR changes the logic to only warn if both mods have the feature enabled to indicate unintended behavior instead of forcing the user to disable SkyHanni's.This PR removes the check entirely.
See related code at https://github.com/hannibal002/SkyHanni/blob/ff6dd291a0f89644508171e6b984295de20466ce/src/main/java/at/hannibal2/skyhanni/features/chat/ChatPeek.kt
How to test
If you use SkyHanni's chat peek without the PR, leave Chatting's chat peek disabled and see how the notification is displayed.
With the PR, you will not see a notification as long as the feature is not enabled in Chatting.With the PR, this message does no longer exist.
Release Notes
Documentation