-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize some PIsList
utilities - add a few more utilities
#87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TotallyNotChase
commented
Jan 11, 2022
TotallyNotChase
changed the title
Optimize some
Optimize some Jan 12, 2022
PList
utilities - add a few more utilitiesPIsList
utilities - add a few more utilities
L-as
requested changes
Jan 12, 2022
Can we put this into staging to reduce merge conflicts later on? |
L-as
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If only we were using Pijul. |
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some missing
phoistAcyclic
s to top level utilities.Remove redundant
plet
usage fromplength
.Make
plistEquals
manually go through both lists at once (usingpelimList
). This should be significantly more efficient thanzipWith
followed byfoldr
.It looks like the entire result of
zipWith
is evaluated beforefoldr
is called.Make
pall
useprecList
directly.Add
pany
.Add
pfoldrLazy
. This takes in a(a :--> PDelayed b :--> b)
, rather than(a :--> b :--> b)
- allowing the fold to short circuit.Add left folds,
pfoldl
andpfoldl'
.Add some tests for
pfoldl
.Closes #79