Improve ArchGetFileName for windows to return full path
#3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nvmkuruc @nvidia-jomiller for vis. |
2 tasks
nvmkuruc
reviewed
Oct 11, 2024
| // Open a file, check that the file path from FILE* handle is matched. | ||
| ARCH_AXIOM((firstFile = ArchOpenFile(firstName.c_str(), "rb")) != NULL); | ||
| std::string filePath = ArchGetFileName(firstFile); | ||
| ARCH_AXIOM(_DosDevicePathFilter(filePath) == _DosDevicePathFilter(firstName)); |
There was a problem hiding this comment.
Would comparing ArchAbsPath be sufficient instead of _DosDevicePathFilter?
|
Filed as internal issue #USD-10302 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
In a fix to improve Alembic plugin to read assets with ArResolver to support other sources except local files (#3302), it provides 4 options and 3 of them are using istream interfaces which has flaws to support layered ABC files. The only solution needs to fix
ArchGetFileNameto return full path fromFILE*.Fixes Issue(s)