Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all the Windows dll path logic into the WindowsImportWrapper #3353

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

tbttfox
Copy link

@tbttfox tbttfox commented Oct 8, 2024

Description of Change(s)

There's already a python context in pxr/tf/__init__.py that handles adding and removing dll paths for windows, so I moved the Windows specific import path logic out of the pxr/__init__.py to there. This way, we don't have to permanently change the PATH

I couldn't get the tests to pass locally from the dev build, even without my changes.
And I couldn't get the release branch to build because boost breaks.
Any suggestions how to deal with this?

However, I was able to test that my changes load the correct DLL's on python 3.7, python 3.11, and anaconda 3.12 both with and without the PXR_USD_WINDOWS_DLL_PATH variable set. (I just copied my changes directly into different pip installs)

Fixes Issue(s)

#3114

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link

Filed as internal issue #USD-10276

❗ Please make sure that a signed CLA has been submitted!

@jesschimein
Copy link

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants