Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add worker queue #630
Add worker queue #630
Changes from all commits
00bc5ce
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Check warning on line 1 in src/errors/JobQueueStateError.ts
Codecov / codecov/patch
src/errors/JobQueueStateError.ts#L1
Check warning on line 52 in src/handlers/bulkUploadsHandlers.ts
Codecov / codecov/patch
src/handlers/bulkUploadsHandlers.ts#L52
Check warning on line 2 in src/index.ts
Codecov / codecov/patch
src/index.ts#L2
Check warning on line 22 in src/index.ts
Codecov / codecov/patch
src/index.ts#L21-L22
Check warning on line 19 in src/jobQueue.ts
Codecov / codecov/patch
src/jobQueue.ts#L19
Check warning on line 34 in src/jobQueue.ts
Codecov / codecov/patch
src/jobQueue.ts#L21-L34
Check warning on line 40 in src/jobQueue.ts
Codecov / codecov/patch
src/jobQueue.ts#L40
Check warning on line 50 in src/jobQueue.ts
Codecov / codecov/patch
src/jobQueue.ts#L50
Check warning on line 16 in src/tasks/processBulkUpload.ts
Codecov / codecov/patch
src/tasks/processBulkUpload.ts#L16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonaowen this is what I did for mocking job helpers -- we only use the
logger
helper, and since this is JUST for test code I think it's OK to be a little more "fast and loose" / not try to mock all the other things that JobHelpers can do. Worst case a future test fails and we expand the mock at that point.