error: useless use of `format!` --> src/commands/migrate.rs:119:26 | 119 | .with_context(|| format!("Writing server.toml"))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Writing server.toml".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

error: useless use of `format!` --> src/commands/migrate.rs:72:26 | 72 | .with_context(|| format!("Writing addons.toml"))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Writing addons.toml".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

error: redundant pattern matching, consider using `is_err()` --> src/api/ws/mod.rs:72:20 | 72 | if let Err(_) = client.send(msg.clone()).await { | -------^^^^^^--------------------------------- help: try: `if (client.send(msg.clone()).await).is_err()` | = note: this will change drop order of the result, as well as all temporaries = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `-D clippy::redundant-pattern-matching` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::redundant_pattern_matching)]`

error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/api/ws/msg.rs:32:1 | 32 | impl Into<Message> for MsgOut { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into help: replace the `Into` implementation with `From<api::ws::msg::MsgOut>` | 32 ~ impl From<MsgOut> for Message { 33 ~ fn from(val: MsgOut) -> Self { 34 ~ Message::text(serde_json::to_string(&val).unwrap()) |

error: large size difference between variants --> src/api/ws/msg.rs:21:1 | 21 | / pub enum MsgOut { 22 | | / Connected { 23 | | | version: String, 24 | | | }, | | |_____- the second-largest variant contains at least 24 bytes 25 | | 26 | | / AppInfo { 27 | | | server: Option<Server>, 28 | | | network: Option<Network>, 29 | | | }, | | |_____- the largest variant contains at least 640 bytes 30 | | } | |___^ the entire enum is at least 640 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `-D clippy::large-enum-variant` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::large_enum_variant)]` help: consider boxing the large fields to reduce the total size of the enum | 27 | server: Box<Option<Server>>, | ~~~~~~~~~~~~~~~~~~~

error: the borrowed expression implements the required traits --> src/api/utils/toml.rs:27:59 | 27 | let data: T = toml::from_str(&std::fs::read_to_string(&path)?)?; | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

error: redundant guard --> src/api/utils/pathdiff.rs:90:39 | 90 | (Some(_), Some(b)) if b == Component::ParentDir => return None, | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards help: try | 90 - (Some(_), Some(b)) if b == Component::ParentDir => return None, 90 + (Some(_), Some(Component::ParentDir)) => return None, |

error: redundant guard --> src/api/utils/pathdiff.rs:89:39 | 89 | (Some(a), Some(b)) if b == Component::CurDir => comps.push(a), | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards = note: `-D clippy::redundant-guards` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::redundant_guards)]` help: try | 89 - (Some(a), Some(b)) if b == Component::CurDir => comps.push(a), 89 + (Some(a), Some(Component::CurDir)) => comps.push(a), |

error: using `clone` on type `HashFormat` which implements the `Copy` trait --> src/api/utils/hashing/mod.rs:58:24 | 58 | .map(|(k, v)| (k.clone(), v.clone())) | ^^^^^^^^^ help: try dereferencing it: `*k` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

error: direct implementation of `ToString` --> src/api/utils/accessor.rs:18:1 | 18 | / impl ToString for Accessor { 19 | | fn to_string(&self) -> String { 20 | | match self { 21 | | Accessor::Local(path) => path.to_string_lossy().into_owned(), ... | 25 | | } 26 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl

error: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` --> src/api/tools/java/installation.rs:50:10 | 50 | .into_iter() | ^^^^^^^^^ help: call directly: `iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref

error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> src/api/sources/buildtools/mod.rs:58:18 | 58 | custom_args: &Vec<String>, | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg help: change this to | 58 ~ custom_args: &[String], 59 | mc_version: &str, ... 75 | 76 ~ args.extend(custom_args.to_owned()); |

error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> src/api/sources/buildtools/mod.rs:32:19 | 32 | _custom_args: &Vec<String>, | ^^^^^^^^^^^^ help: change this to: `&[String]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

error: question mark operator is useless here --> src/api/sources/spigot/mod.rs:23:9 | 23 | Ok(self.0.http_get_json(format!("{}/{url}", self.0.options.api_urls.spiget)).await?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `self.0.http_get_json(format!("{}/{url}", self.0.options.api_urls.spiget)).await` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark

error: empty doc comment --> src/api/sources/hangar/models.rs:268:1 | 268 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs = note: `-D clippy::empty-docs` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::empty_docs)]`

error: direct implementation of `ToString` --> src/api/sources/hangar/models.rs:180:1 | 180 | / impl ToString for Platform { 181 | | fn to_string(&self) -> String { 182 | | match self { 183 | | Self::Paper => "PAPER".to_owned(), ... | 187 | | } 188 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl

error: direct implementation of `ToString` --> src/api/sources/hangar/models.rs:12:1 | 12 | / impl ToString for Namespace { 13 | | fn to_string(&self) -> String { 14 | | format!("{}/{}", self.owner, self.slug) 15 | | } 16 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/api/sources/papermc/mod.rs:71:56 | 71 | let resolved_build = self.fetch_build(project, &version, build).await?; | ^^^^^^^^ help: change this to: `version` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: methods called `into_*` usually take `self` by value --> src/api/sources/vanilla/mod.rs:20:22 | 20 | pub fn into_step(&self, ty: DownloadType) -> Option<Vec<Step>> { | ^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention

error: useless conversion to the same type: `std::string::String` --> src/api/sources/url/mod.rs:25:14 | 25 | url: url.into(), | ^^^^^^^^^^ help: consider removing `.into()`: `url` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::useless_conversion)]`

error: called `map(..).flatten()` on `Option` --> src/api/sources/modrinth/mod.rs:53:42 | 53 | if let Some(id) = store.as_ref().map(|ids| ids.get(slug)).flatten() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|ids| ids.get(slug))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten

error: question mark operator is useless here --> src/api/sources/modrinth/mod.rs:33:9 | 33 | Ok(self.fetch_all_versions(id).await?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `self.fetch_all_versions(id).await` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark

error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/api/sources/curseforge/mod.rs:86:1 | 86 | impl Into<HashFormat> for CurseforgeHashAlgo { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `-D clippy::from-over-into` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::from_over_into)]` help: replace the `Into` implementation with `From<api::sources::curseforge::models::CurseforgeHashAlgo>` | 86 ~ impl From<CurseforgeHashAlgo> for HashFormat { 87 ~ fn from(val: CurseforgeHashAlgo) -> Self { 88 ~ match val { |

error: struct update has no effect, all the fields in the struct have already been specified --> src/api/sources/curseforge/mod.rs:67:15 | 67 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

error: struct update has no effect, all the fields in the struct have already been specified --> src/api/sources/curseforge/mod.rs:50:15 | 50 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update = note: `-D clippy::needless-update` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::needless_update)]`

error: methods called `into_*` usually take `self` by value --> src/api/models/metadata/addon_metadata.rs:41:21 | 41 | pub fn into_str(&self) -> &'static str { | ^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention

error: direct implementation of `ToString` --> src/api/models/markdown/mod.rs:64:1 | 64 | / impl ToString for MdColumn { 65 | | fn to_string(&self) -> String { 66 | | match self { 67 | | MdColumn::Icon => String::from("."), ... | 73 | | } 74 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl

error: name `HTML` contains a capitalized acronym --> src/api/models/markdown/mod.rs:14:5 | 14 | HTML, | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Html` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms

error: name `ASCII` contains a capitalized acronym --> src/api/models/markdown/mod.rs:13:5 | 13 | ASCII, | ^^^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Ascii` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms = note: `-D clippy::upper-case-acronyms` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::upper_case_acronyms)]`

error: using `clone` on type `ServerFlavor` which implements the `Copy` trait --> src/api/models/server/server_type.rs:107:50 | 107 | ServerType::Custom { flavor, .. } => flavor.clone(), | ^^^^^^^^^^^^^^ help: try dereferencing it: `*flavor` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-D clippy::clone-on-copy` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::clone_on_copy)]`

error: direct implementation of `ToString` --> src/api/models/server/server_type.rs:22:1 | 22 | / impl ToString for PaperMCProject { 23 | | fn to_string(&self) -> String { 24 | | match self { 25 | | Self::Paper => "paper".to_owned(), ... | 29 | | } 30 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl

error: match expression looks like `matches!` macro --> src/api/models/server/server_flavor.rs:46:9 | 46 | / match self { 47 | | ServerFlavor::Patched => true, 48 | | _ => false, 49 | | } | |_________^ help: try: `matches!(self, ServerFlavor::Patched)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro

error: match expression looks like `matches!` macro --> src/api/models/server/server_flavor.rs:39:9 | 39 | / match self { 40 | | ServerFlavor::Proxy => false, 41 | | _ => true, 42 | | } | |_________^ help: try: `!matches!(self, ServerFlavor::Proxy)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro

error: match expression looks like `matches!` macro --> src/api/models/server/server_flavor.rs:23:9 | 23 | / match self { 24 | | ServerFlavor::Modded => true, 25 | | _ => false, 26 | | } | |_________^ help: try: `matches!(self, ServerFlavor::Modded)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro

error: match expression looks like `matches!` macro --> src/api/models/server/server_flavor.rs:16:9 | 16 | / match self { 17 | | ServerFlavor::Proxy => false, 18 | | _ => true, 19 | | } | |_________^ help: try: `!matches!(self, ServerFlavor::Proxy)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro = note: `-D clippy::match-like-matches-macro` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::match_like_matches_macro)]`

error: methods called `into_*` usually take `self` by value --> src/api/models/packwiz/mod.rs:66:29 | 66 | pub async fn into_addon(&self, app: &App, target: AddonTarget) -> Result<Addon> { | ^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention

error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> src/api/models/packwiz/mod.rs:45:36 | 45 | pub async fn from_steps(steps: &Vec<Step>) -> Self { | ^^^^^^^^^^ help: change this to: `&[Step]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

error: methods called `into_*` usually take `self` by value --> src/api/models/mrpack/mod.rs:28:29 | 28 | pub async fn into_addon(&self) -> Result<Addon> { | ^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `-D clippy::wrong-self-convention` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::wrong_self_convention)]`

error: this `impl` can be derived --> src/api/models/lockfile/mod.rs:18:1 | 18 | / impl Default for Lockfile { 19 | | fn default() -> Self { 20 | | Self { 21 | | addons: vec![], ... | 25 | | } 26 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `-D clippy::derivable-impls` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::derivable_impls)]` = help: remove the manual implementation... help: ...and instead derive it | 12 + #[derive(Default)] 13 | pub struct Lockfile { |

error: module has the same name as its containing module --> src/api/models/addon/mod.rs:1:1 | 1 | mod addon; | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `-D clippy::module-inception` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::module_inception)]`

error: direct implementation of `ToString` --> src/api/models/modpack_source.rs:47:1 | 47 | / impl ToString for ModpackType { 48 | | fn to_string(&self) -> String { 49 | | match self { 50 | | ModpackType::Packwiz => String::from("Packwiz"), ... | 54 | | } 55 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl

error: question mark operator is useless here --> src/api/models/modpack_source.rs:28:9 | 28 | Ok(Accessor::from(str)?) | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `Accessor::from(str)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark

error: direct implementation of `ToString` --> src/api/models/env.rs:16:1 | 16 | / impl ToString for Environment { 17 | | fn to_string(&self) -> String { 18 | | match self { 19 | | Environment::Both => String::from("both"), ... | 23 | | } 24 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl = note: `-D clippy::to-string-trait-impl` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::to_string_trait_impl)]`

error: useless use of `format!` --> src/api/app/step/mod.rs:40:38 | 40 | .with_context(|| format!("Downloading a file")) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Downloading a file".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `-D clippy::useless-format` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::useless_format)]`

error: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` --> src/api/app/step/execute_java.rs:19:14 | 19 | .into_iter() | ^^^^^^^^^ help: call directly: `iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref = note: `-D clippy::into-iter-on-ref` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::into_iter_on_ref)]`

error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> src/api/app/step/execute_java.rs:11:15 | 11 | args: &Vec<String>, | ^^^^^^^^^^^^ help: change this to: `&[String]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `-D clippy::ptr-arg` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::ptr_arg)]`

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/api/app/step/download.rs:34:24 | 34 | create_parents(&target_destination).await?; | ^^^^^^^^^^^^^^^^^^^ help: change this to: `target_destination` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: question mark operator is useless here --> src/api/app/http.rs:65:9 | 65 | / Ok(serde_json::from_slice(&full) 66 | | .with_context(|| format!("JSON parsing error: {}", String::from_utf8_lossy(&full)))?) | |_________________________________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `-D clippy::needless-question-mark` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::needless_question_mark)]` help: try removing question mark and `Ok()` | 65 ~ serde_json::from_slice(&full) 66 + .with_context(|| format!("JSON parsing error: {}", String::from_utf8_lossy(&full))) |

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/api/app/collect.rs:22:61 | 22 | addons.extend_from_slice(&source.resolve_addons(&self).await?); | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: called `map(..).flatten()` on `Option` --> src/api/app/actions/build/bootstrap.rs:87:75 | 87 | let lockfile_entry = self.existing_lockfile.read().await.as_ref().map(|lock| lock.bootstrapped_files.get(file)).flatten().cloned(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|lock| lock.bootstrapped_files.get(file))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/api/app/actions/build/server_jar.rs:15:43 | 15 | let steps = jar.resolve_steps(&self, Environment::Server).await?; | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::needless_borrow)]`

error: called `map(..).flatten()` on `Option` --> src/api/app/actions/build/server_jar.rs:10:62 | 10 | if let Some(jar) = self.server.read().await.as_ref().map(|(_, server)| { | ______________________________________________________________^ 11 | | server.jar.clone() 12 | | }).flatten() { | |____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten = note: `-D clippy::map-flatten` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::map_flatten)]` help: try replacing `map` with `and_then` and remove the `.flatten()` | 10 ~ if let Some(jar) = self.server.read().await.as_ref().and_then(|(_, server)| { 11 + server.jar.clone() 12 ~ }) { |

error: lint group `pedantic` has the same priority (0) as a lint --> Cargo.toml:24:1 | 24 | pedantic = "warn" | ^^^^^^^^ ------ has an implicit priority of 0 25 | missing_docs_in_private_items = "allow" | ----------------------------- has the same priority as this lint | = note: the order of the lints in the table is ignored by Cargo = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority help: to have lints override the group set `pedantic` to a lower priority | 24 | pedantic = { level = "warn", priority = -1 } | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `all` has the same priority (0) as a lint --> Cargo.toml:23:1 | 23 | all = "deny" | ^^^ ------ has an implicit priority of 0 24 | pedantic = "warn" 25 | missing_docs_in_private_items = "allow" | ----------------------------- has the same priority as this lint | = note: the order of the lints in the table is ignored by Cargo = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority = note: `-D clippy::lint-groups-priority` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::lint_groups_priority)]` help: to have lints override the group set `all` to a lower priority | 23 | all = { level = "deny", priority = -1 } | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: unneeded unit return type --> src/api/tools/java/mod.rs:44:37 | 44 | pub fn lines<F>(&mut self, f: F) -> () | ^^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `-D clippy::unused-unit` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::unused_unit)]`

Clippy had exited with the 101 exit code

warning: unused `std::result::Result` that must be used --> src/main.rs:36:5 | 36 | init_logger(); | ^^^^^^^^^^^^^ | = note: this `Result` may be an `Err` variant, which should be handled = note: `#[warn(unused_must_use)]` on by default help: use `let _ = ...` to ignore the resulting value | 36 | let _ = init_logger(); | +++++++

warning: unused `async` for function with no await statements --> src/commands/migrate.rs:38:1 | 38 | / pub async fn migrate_server() -> Result<()> { 39 | | let legacy_server = read_toml::<LegacyServer>(&PathBuf::from("./server.toml")) 40 | | .with_context(|| "Reading server.toml")?; ... | 123 | | Ok(()) 124 | | } | |_^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/commands/markdown/print.rs:10:1 | 10 | / pub async fn run(app: Arc<App>, args: Args) -> Result<()> { 11 | | todo!(); 12 | | 13 | | Ok(()) 14 | | } | |_^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/ws/mod.rs:84:5 | 84 | / pub async fn handle_event(self: Arc<Self>, event: MsgIn) -> Result<()> { 85 | | 86 | | 87 | | Ok(()) 88 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/utils/zip.rs:45:1 | 45 | / pub async fn zip<T: Write + Seek>(writer: T, folder: &Path) -> Result<()> { 46 | | let mut archive = ZipWriter::new(writer); 47 | | 48 | | archive.set_comment(format!("generated by mcman/{APP_VERSION}")); ... | 67 | | Ok(()) 68 | | } | |_^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/utils/zip.rs:12:1 | 12 | / pub async fn unzip<T: Read + Seek>(reader: T, to: &Path, prefix: Option<String>) -> Result<()> { 13 | | let mut archive = ZipArchive::new(reader)?; 14 | | 15 | | let mut files = archive.file_names().map(ToOwned::to_owned).collect::<Vec<_>>(); ... | 41 | | Ok(()) 42 | | } | |_^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/utils/accessor.rs:42:5 | 42 | / pub async fn dir(&self) -> Result<Vec<String>> { 43 | | match self { 44 | | Accessor::ZipLocal(zip) => Ok(zip.file_names().map(ToOwned::to_owned).collect()), 45 | | Accessor::Local(path) => Ok(path ... | 51 | | } 52 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/sources/quilt/mod.rs:59:5 | 59 | / pub async fn resolve_steps_build( 60 | | &self, 61 | | jar_name: &str, 62 | | mc_version: &str, ... | 92 | | ]) 93 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/sources/buildtools/mod.rs:54:1 | 54 | / pub async fn resolve_compile_steps( 55 | | _app: &App, 56 | | jar_name: &str, 57 | | craftbukkit: bool, ... | 92 | | ]) 93 | | } | |_^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/sources/buildtools/mod.rs:29:1 | 29 | / pub async fn resolve_remove_steps( 30 | | _app: &App, 31 | | _craftbukkit: bool, 32 | | _custom_args: &Vec<String>, ... | 35 | | Ok(vec![Step::RemoveFile(FileMeta::filename(String::from("server.jar")))]) 36 | | } | |_^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/sources/spigot/mod.rs:71:5 | 71 | / pub async fn resolve_remove_steps(&self, id: &str, version: &str) -> Result<Vec<Step>> { 72 | | Ok(vec![ 73 | | Step::RemoveFile(FileMeta::filename(format!("spigot-{}-{}.jar", resource_id(id), version))) 74 | | ]) 75 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/sources/spigot/mod.rs:51:5 | 51 | / pub async fn resolve_steps(&self, id: &str, version: &str) -> Result<Vec<Step>> { 52 | | let url = format!( 53 | | "{}/resources/{}/versions/{}/download/proxy", 54 | | self.0.options.api_urls.spiget, ... | 68 | | ]) 69 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/sources/fabric/mod.rs:25:5 | 25 | / pub async fn resolve_steps( 26 | | &self, 27 | | mc_version: &str, 28 | | loader: &str, ... | 64 | | Ok(steps) 65 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/sources/maven/mod.rs:83:5 | 83 | / pub async fn resolve( 84 | | &self, 85 | | url: &str, 86 | | group_id: &str, ... | 116 | | Ok((download_url, metadata)) 117 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/models/packwiz/mod.rs:66:5 | 66 | / pub async fn into_addon(&self, app: &App, target: AddonTarget) -> Result<Addon> { 67 | | let addon_type = if let Some(update) = &self.update { 68 | | match update { 69 | | PackwizModUpdate::Modrinth { mod_id, version } => AddonType::Modrinth { ... | 95 | | Ok(addon) 96 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/models/packwiz/mod.rs:45:5 | 45 | / pub async fn from_steps(steps: &Vec<Step>) -> Self { 46 | | todo!() 47 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/models/mrpack/mod.rs:28:5 | 28 | / pub async fn into_addon(&self) -> Result<Addon> { 29 | | Ok(Addon { 30 | | environment: self.env.as_ref().map(|e| e.clone().into()), 31 | | addon_type: AddonType::Url { ... | 39 | | }) 40 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/app/actions/init/mod.rs:46:5 | 46 | / pub async fn action_init_network(&self) -> Result<()> { 47 | | cliclack::intro("initializing network")?; 48 | | 49 | | let name: String = cliclack::input("Name of the network?").interact()?; ... | 55 | | Ok(()) 56 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/app/actions/build/bootstrap.rs:65:5 | 65 | / pub async fn should_bootstrap_file(&self, file: &Path) -> bool { 66 | | let ext = file.extension().unwrap_or_default().to_str().unwrap_or_default(); 67 | | 68 | | let bootstrap_exts = [ ... | 81 | | bootstrap_exts.contains(&ext) 82 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async = note: `-W clippy::unused-async` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::unused_async)]`

warning: item in documentation is missing backticks --> src/api/ws/mod.rs:1:5 | 1 | //! WebSocket Server implementation for third party editors | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 1 | //! `WebSocket` Server implementation for third party editors | ~~~~~~~~~~~

warning: this function's return value is unnecessary --> src/api/utils/logger/mod.rs:3:1 | 3 | / pub fn init_logger() -> Result<()> { 4 | | env_logger::init(); 5 | | 6 | | Ok(()) 7 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps = note: `-W clippy::unnecessary-wraps` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_wraps)]` help: remove the return type... | 3 | pub fn init_logger() -> Result<()> { | ~~~~~~~~~~ help: ...and then remove returned values | 6 - Ok(()) 6 + |

warning: consider adding a `;` to the last statement for consistent formatting --> src/api/utils/zip.rs:19:13 | 19 | / files = files.into_iter() 20 | | .map(|f| f.replacen(&prefix, "", 1)) 21 | | .collect() | |__________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned help: add a `;` here | 19 ~ files = files.into_iter() 20 + .map(|f| f.replacen(&prefix, "", 1)) 21 + .collect(); |

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/utils/script.rs:45:24 | 45 | pub fn script_args(&self) -> &'static str { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/utils/script.rs:38:21 | 38 | pub fn line_sep(&self) -> &'static str { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/utils/script.rs:31:21 | 31 | pub fn file_ext(&self) -> &'static str { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/utils/script.rs:24:19 | 24 | pub fn header(&self) -> &'static str { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/utils/script.rs:17:20 | 17 | pub fn comment(&self, comment: &str) -> String { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/utils/script.rs:8:28 | 8 | pub fn generate_script(&self, lines: Vec<String>) -> String { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument is passed by value, but not consumed in the function body --> src/api/utils/script.rs:8:42 | 8 | pub fn generate_script(&self, lines: Vec<String>) -> String { | ^^^^^^^^^^^ help: consider changing the type to: `&[String]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value

warning: called `.collect::<Vec<String>>().join("")` on an iterator --> src/api/utils/markdown/mod.rs:96:16 | 96 | li.collect::<Vec<_>>().join("") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `collect::<String>()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_join = note: `-W clippy::unnecessary-join` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_join)]`

warning: this argument is passed by value, but not consumed in the function body --> src/api/utils/markdown/mod.rs:91:45 | 91 | fn wrap(tag: &'static str, content: String) -> String { | ^^^^^^ help: consider changing the type to: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/utils/serde.rs:41:19 | 41 | pub fn is_true(b: &bool) -> bool { | ^^^^^ help: consider passing by value instead: `bool` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: unnecessary `!=` operation --> src/api/utils/pathdiff.rs:69:5 | 69 | / if path.is_absolute() != base.is_absolute() { 70 | | if path.is_absolute() { 71 | | Some(PathBuf::from(path)) 72 | | } else { ... | 102 | | Some(comps.iter().map(|c| c.as_os_str()).collect()) 103 | | } | |_____^ | = help: change to `==` and swap the blocks of the `if`/`else` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else

warning: usage of wildcard import --> src/api/utils/pathdiff.rs:3:5 | 3 | use std::path::*; | ^^^^^^^^^^^^ help: try: `std::path::{Component, Path, PathBuf}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: you should put bare URLs between `<`/`>` or make a proper Markdown link --> src/api/utils/pathdiff.rs:1:5 | 1 | //! https://github.com/Manishearth/pathdiff | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/utils/hashing/mod.rs:25:23 | 25 | pub fn get_digest(&self) -> Box<dyn DynDigest + Send> { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: consider adding a `;` to the last statement for consistent formatting --> src/api/utils/hashing/curseforge.rs:24:9 | 24 | self.0 = Vec::new() | ^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.0 = Vec::new();` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned

warning: consider adding a `;` to the last statement for consistent formatting --> src/api/utils/hashing/curseforge.rs:14:9 | 14 | / self.0.extend( 15 | | data.iter() 16 | | .copied() 17 | | .filter(|&e| e != 9 && e != 10 && e != 13 && e != 32), 18 | | ) | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned = note: `-W clippy::semicolon-if-nothing-returned` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::semicolon_if_nothing_returned)]` help: add a `;` here | 14 ~ self.0.extend( 15 + data.iter() 16 + .copied() 17 + .filter(|&e| e != 9 && e != 10 && e != 13 && e != 32), 18 + ); |

warning: redundant closure --> src/api/utils/accessor.rs:47:29 | 47 | .filter_map(|r| r.ok()) | ^^^^^^^^^^ help: replace the closure with the method itself: `std::result::Result::ok` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls

warning: case-sensitive file extension comparison --> src/api/utils/accessor.rs:32:19 | 32 | } else if str.ends_with(".zip") || str.ends_with(".mrpack") { | ^^^^^^^^^^^^^^^^^^^^^ | = help: consider using a case-insensitive comparison instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#case_sensitive_file_extension_comparisons help: use std::path::Path | 32 ~ } else if std::path::Path::new(str) 33 + .extension() 34 ~ .map_or(false, |ext| ext.eq_ignore_ascii_case("zip")) || str.ends_with(".mrpack") { |

warning: unnecessary `!=` operation --> src/api/tools/java/check.rs:10:16 | 10 | let path = if path.file_name()?.to_str()? != JAVA_BIN { | ________________^ 11 | | path.join(JAVA_BIN) 12 | | } else { 13 | | path.clone() 14 | | }; | |_____^ | = help: change to `==` and swap the blocks of the `if`/`else` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else = note: `-W clippy::if-not-else` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::if_not_else)]`

warning: this match arm has an identical body to another arm --> src/api/tools/java/installation.rs:23:13 | 23 | (Some("1"), Some(ver)) => ver, | ----------------------^^^^^^^ | | | help: try merging the arm patterns: `(Some("1"), Some(ver)) | (Some(ver), _)` | = help: or try changing either arm body note: other arm here --> src/api/tools/java/installation.rs:24:13 | 24 | (Some(ver), _) => ver, | ^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: wildcard matches only a single variant and will also match any future added variants --> src/api/sources/quilt/mod.rs:83:13 | 83 | _ => {}, | ^ help: try: `Environment::Both` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wildcard_for_single_variants

warning: item in documentation is missing backticks --> src/api/sources/buildtools/mod.rs:53:29 | 53 | /// Resolve steps for using BuildTools to compile a server jar | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 53 | /// Resolve steps for using `BuildTools` to compile a server jar | ~~~~~~~~~~~~

warning: wildcard matches only a single variant and will also match any future added variants --> src/api/sources/vanilla/mod.rs:57:13 | 57 | _ => bail!("You cant have both smh"), | ^ help: try: `Environment::Both` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wildcard_for_single_variants = note: `-W clippy::match-wildcard-for-single-variants` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::match_wildcard_for_single_variants)]`

warning: item in documentation is missing backticks --> src/api/sources/vanilla/version.rs:179:10 | 179 | /// (AssetIndex only) The size of the game version's assets | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 179 | /// (`AssetIndex` only) The size of the game version's assets | ~~~~~~~~~~~~

warning: item in documentation is missing backticks --> src/api/sources/vanilla/version.rs:177:10 | 177 | /// (AssetIndex only) The game version ID the assets are for | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 177 | /// (`AssetIndex` only) The game version ID the assets are for | ~~~~~~~~~~~~

warning: item in documentation is missing backticks --> src/api/sources/vanilla/version.rs:149:13 | 149 | /// The HashMap key specifies a classifier as additional information for downloading files | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 149 | /// The `HashMap` key specifies a classifier as additional information for downloading files | ~~~~~~~~~

warning: possible intra-doc link using quotes instead of backticks --> src/api/sources/vanilla/version.rs:87:25 | 87 | /// "exclude": ["META-INF/"], | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_link_with_quotes = note: `-W clippy::doc-link-with-quotes` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::doc_link_with_quotes)]`

warning: all fields have the same postfix: `url` --> src/api/sources/curseforge/models.rs:27:1 | 27 | / pub struct CurseforgeModLinks { 28 | | pub website_url: String, 29 | | pub wiki_url: String, 30 | | pub issues_url: String, 31 | | pub source_url: String, 32 | | } | |_^ | = help: remove the postfixes = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#struct_field_names

warning: usage of wildcard import --> src/api/models/legacy/server_launcher.rs:5:5 | 5 | use crate::api::utils::serde::*; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crate::api::utils::serde::is_default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> src/api/models/legacy/server_type.rs:2:5 | 2 | use crate::api::utils::serde::*; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crate::api::utils::serde::str_latest` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> src/api/models/launcher/mod.rs:5:5 | 5 | use crate::api::utils::serde::*; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crate::api::utils::serde::is_default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/metadata/addon_metadata.rs:62:21 | 62 | pub fn icon_url(&self) -> String { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/metadata/addon_metadata.rs:58:17 | 58 | pub fn html(&self) -> String { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/metadata/addon_metadata.rs:54:25 | 54 | pub fn markdown_tag(&self) -> String { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/metadata/addon_metadata.rs:41:21 | 41 | pub fn into_str(&self) -> &'static str { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument is passed by value, but not consumed in the function body --> src/api/models/markdown/render.rs:10:38 | 10 | pub fn table_addons(&self, list: Vec<AddonMetadata>, output: MarkdownOutput) -> MarkdownTable { | ^^^^^^^^^^^^^^^^^^ help: consider changing the type to: `&[AddonMetadata]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value = note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]`

warning: usage of wildcard import --> src/api/models/markdown/mod.rs:6:5 | 6 | use crate::api::utils::serde::*; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crate::api::utils::serde::{bool_true, is_default, is_true}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: redundant closure --> src/api/models/server/mod.rs:59:31 | 59 | self.jar.as_ref().map(|s| s.get_execution_arguments()).unwrap_or_default() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `server_type::ServerJar::get_execution_arguments` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls = note: `-W clippy::redundant-closure-for-method-calls` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::redundant_closure_for_method_calls)]`

warning: this match arm has an identical body to another arm --> src/api/models/server/server_type.rs:178:13 | 178 | ServerType::BuildTools { .. } => Ok(false), | -----------------------------^^^^^^^^^^^^^ | | | help: try merging the arm patterns: `ServerType::BuildTools { .. } | ServerType::Vanilla { }` | = help: or try changing either arm body note: other arm here --> src/api/models/server/server_type.rs:152:13 | 152 | ServerType::Vanilla { } => Ok(false), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: usage of wildcard import --> src/api/models/server/server_type.rs:2:102 | 2 | app::App, models::{Addon, AddonTarget, AddonType, Environment}, sources::buildtools, step::Step, utils::serde::* | ^^^^^^^^^^^^^^^ help: try: `utils::serde::str_latest` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports = note: `-W clippy::wildcard-imports` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::wildcard_imports)]`

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/server/server_flavor.rs:45:31 | 45 | pub fn supports_eula_args(&self) -> bool { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/server/server_flavor.rs:38:27 | 38 | pub fn supports_nogui(&self) -> bool { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this match arm has an identical body to another arm --> src/api/models/server/server_flavor.rs:33:13 | 33 | ServerFlavor::Patched => true, | ---------------------^^^^^^^^ | | | help: try merging the arm patterns: `ServerFlavor::Patched | ServerFlavor::Proxy` | = help: or try changing either arm body note: other arm here --> src/api/models/server/server_flavor.rs:34:13 | 34 | ServerFlavor::Proxy => true, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> src/api/models/server/server_flavor.rs:32:13 | 32 | ServerFlavor::Modded => false, | --------------------^^^^^^^^^ | | | help: try merging the arm patterns: `ServerFlavor::Modded | ServerFlavor::Vanilla` | = help: or try changing either arm body note: other arm here --> src/api/models/server/server_flavor.rs:31:13 | 31 | ServerFlavor::Vanilla => false, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/server/server_flavor.rs:29:29 | 29 | pub fn supports_plugins(&self) -> bool { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/server/server_flavor.rs:22:26 | 22 | pub fn supports_mods(&self) -> bool { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/server/server_flavor.rs:15:31 | 15 | pub fn supports_datapacks(&self) -> bool { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: called `map(<f>).unwrap_or(<a>)` on an `Option` value --> src/api/models/addon/addon_target.rs:38:14 | 38 | &Path::new(path) | ______________^ 39 | | .parent() 40 | | .map(|p| p.to_string_lossy().into_owned()) 41 | | .unwrap_or(".".to_owned()), | |__________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or help: use `map_or(<a>, <f>)` instead | 40 - .map(|p| p.to_string_lossy().into_owned()) 40 + .map_or(".".to_owned(), |p| p.to_string_lossy().into_owned()), |

warning: field name starts with the struct's name --> src/api/models/addon/addon.rs:13:5 | 13 | pub addon_type: AddonType, | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#struct_field_names = note: `-W clippy::struct-field-names` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::struct_field_names)]`

warning: case-sensitive file extension comparison --> src/api/models/source.rs:60:71 | 60 | let file: AddonListFile = read_toml(&PathBuf::from(if path.ends_with(".toml") { | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider using a case-insensitive comparison instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#case_sensitive_file_extension_comparisons = note: `-W clippy::case-sensitive-file-extension-comparisons` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::case_sensitive_file_extension_comparisons)]` help: use std::path::Path | 60 ~ let file: AddonListFile = read_toml(&PathBuf::from(if std::path::Path::new(path) 61 + .extension() 62 ~ .map_or(false, |ext| ext.eq_ignore_ascii_case("toml")) { |

warning: this match arm has an identical body to another arm --> src/api/models/source.rs:45:13 | 45 | SourceType::Folder { path } => Ok(Accessor::Local(path.into())), | ---------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: try merging the arm patterns: `SourceType::Folder { path } | SourceType::File { path }` | = help: or try changing either arm body note: other arm here --> src/api/models/source.rs:44:13 | 44 | SourceType::File { path } => Ok(Accessor::Local(path.into())), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> src/api/models/modpack_source.rs:34:13 | 34 | Self::Remote { modpack_type, .. } => *modpack_type, | ---------------------------------^^^^^^^^^^^^^^^^^ | | | help: try merging the arm patterns: `Self::Remote { modpack_type, .. } | Self::Local { modpack_type, .. }` | = help: or try changing either arm body note: other arm here --> src/api/models/modpack_source.rs:33:13 | 33 | Self::Local { modpack_type, .. } => *modpack_type, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms = note: `-W clippy::match-same-arms` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::match_same_arms)]`

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/env.rs:31:19 | 31 | pub fn client(&self) -> bool { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/env.rs:27:19 | 27 | pub fn server(&self) -> bool { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref = note: `-W clippy::trivially-copy-pass-by-ref` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::trivially_copy_pass_by_ref)]`

warning: item in documentation is missing backticks --> src/api/app/step/mod.rs:16:49 | 16 | /// Skips the next step when a step returns StepResult::Skip | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 16 | /// Skips the next step when a step returns `StepResult::Skip` | ~~~~~~~~~~~~~~~~~~

warning: item in documentation is missing backticks --> src/api/app/step/mod.rs:15:55 | 15 | /// Execute a list of steps, taking care of their StepResult's. | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown = note: `-W clippy::doc-markdown` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::doc_markdown)]` help: try | 15 | /// Execute a list of steps, taking care of their `StepResult`'s. | ~~~~~~~~~~~~

warning: called `map(<f>).unwrap_or(<a>)` on an `Option` value --> src/api/app/step/execute_java.rs:36:55 | 36 | bail!("Java process exited with code {}", res.code().map(|x| x.to_string()).unwrap_or("unknown".to_owned())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or help: use `map_or(<a>, <f>)` instead | 36 - bail!("Java process exited with code {}", res.code().map(|x| x.to_string()).unwrap_or("unknown".to_owned())); 36 + bail!("Java process exited with code {}", res.code().map_or("unknown".to_owned(), |x| x.to_string())); |

warning: called `map(<f>).unwrap_or(<a>)` on an `Option` value --> src/api/app/step/execute_java.rs:21:88 | 21 | ...or higher not found, cannot proceed", version.map(|v| v.to_string()).unwrap_or("any".to_owned())))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or help: use `map_or(<a>, <f>)` instead | 21 - .ok_or(anyhow!("Java with version {} or higher not found, cannot proceed", version.map(|v| v.to_string()).unwrap_or("any".to_owned())))?; 21 + .ok_or(anyhow!("Java with version {} or higher not found, cannot proceed", version.map_or("any".to_owned(), |v| v.to_string())))?; |

warning: adding items after statements is confusing, since items exist from the start of the scope --> src/api/app/step/execute_java.rs:27:9 | 27 | / fn on_line(line: &str) { 28 | | println!("| {line}"); 29 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_statements

warning: called `map(<f>).unwrap_or(<a>)` on an `Option` value --> src/api/app/actions/script/mod.rs:22:13 | 22 | get_java_installation_for(*v).await.map(|j| j.path.to_string_lossy().into_owned()).unwrap_or(String::from("java")) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or = note: `-W clippy::map-unwrap-or` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::map_unwrap_or)]` help: use `map_or(<a>, <f>)` instead | 22 - get_java_installation_for(*v).await.map(|j| j.path.to_string_lossy().into_owned()).unwrap_or(String::from("java")) 22 + get_java_installation_for(*v).await.map_or(String::from("java"), |j| j.path.to_string_lossy().into_owned()) |

warning: adding items after statements is confusing, since items exist from the start of the scope --> src/api/app/actions/build/bootstrap.rs:38:9 | 38 | const MAX_CONCURRENT_TASKS: usize = 20; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_statements = note: `-W clippy::items-after-statements` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::items_after_statements)]`

warning: associated items `new`, `start`, `handle_connection`, `broadcast`, and `handle_event` are never used --> src/api/ws/mod.rs:24:12 | 23 | impl WebsocketServer { | -------------------- associated items in this implementation 24 | pub fn new(app: App) -> Arc<Self> { | ^^^ ... 31 | pub async fn start(self: Arc<Self>, addr: &str) -> Result<()> { | ^^^^^ ... 43 | pub async fn handle_connection(self: Arc<Self>, stream: TcpStream) -> Result<()> { | ^^^^^^^^^^^^^^^^^ ... 64 | pub async fn broadcast(self: Arc<Self>, event: MsgOut) -> Result<()> { | ^^^^^^^^^ ... 84 | pub async fn handle_event(self: Arc<Self>, event: MsgIn) -> Result<()> { | ^^^^^^^^^^^^

warning: struct `WebsocketServer` is never constructed --> src/api/ws/mod.rs:18:12 | 18 | pub struct WebsocketServer { | ^^^^^^^^^^^^^^^

warning: type alias `WebsocketStream` is never used --> src/api/ws/mod.rs:16:10 | 16 | pub type WebsocketStream = SplitStream<WebSocketStream<TcpStream>>; | ^^^^^^^^^^^^^^^

warning: type alias `WebsocketSink` is never used --> src/api/ws/mod.rs:15:10 | 15 | pub type WebsocketSink = SplitSink<WebSocketStream<TcpStream>, Message>; | ^^^^^^^^^^^^^

warning: function `some_if_exists` is never used --> src/api/utils/fs.rs:18:8 | 18 | pub fn some_if_exists<T: ?Sized + AsRef<OsStr>>(path: &T) -> Option<PathBuf> { | ^^^^^^^^^^^^^^

warning: function `zip` is never used --> src/api/utils/zip.rs:45:14 | 45 | pub async fn zip<T: Write + Seek>(writer: T, folder: &Path) -> Result<()> { | ^^^

warning: function `unzip` is never used --> src/api/utils/zip.rs:12:14 | 12 | pub async fn unzip<T: Read + Seek>(reader: T, to: &Path, prefix: Option<String>) -> Result<()> { | ^^^^^

warning: field `1` is never read --> src/api/utils/markdown/mod.rs:62:39 | 62 | pub struct MarkdownHeader(pub String, pub HeaderAlignment); | -------------- ^^^^^^^^^^^^^^^^^^^ | | | field in this struct | help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 62 | pub struct MarkdownHeader(pub String, ()); | ~~

warning: variants `Left` and `Right` are never constructed --> src/api/utils/markdown/mod.rs:56:5 | 55 | pub enum HeaderAlignment { | --------------- variants in this enum 56 | Left, | ^^^^ ... 59 | Right, | ^^^^^ | = note: `HeaderAlignment` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

warning: associated items `new` and `generate` are never used --> src/api/utils/markdown/mod.rs:17:12 | 13 | / impl<T> MarkdownTableGenerator<T> 14 | | where 15 | | T: Serialize + std::fmt::Debug | |__________________________________- associated items in this implementation 16 | { 17 | pub fn new(items: Vec<T>) -> Self { | ^^^ ... 21 | pub fn generate(self) -> Result<MarkdownTable> { | ^^^^^^^^

warning: struct `MarkdownTableGenerator` is never constructed --> src/api/utils/markdown/mod.rs:7:12 | 7 | pub struct MarkdownTableGenerator<T> | ^^^^^^^^^^^^^^^^^^^^^^

warning: method `dir` is never used --> src/api/utils/accessor.rs:42:18 | 28 | impl Accessor { | ------------- method in this implementation ... 42 | pub async fn dir(&self) -> Result<Vec<String>> { | ^^^

warning: function `git_check` is never used --> src/api/tools/git/mod.rs:16:8 | 16 | pub fn git_check() -> Option<String> { | ^^^^^^^^^

warning: function `git_command` is never used --> src/api/tools/git/mod.rs:7:8 | 7 | pub fn git_command<I: IntoIterator<Item = S>, S: AsRef<OsStr>>(args: I) -> Result<String> { | ^^^^^^^^^^^

warning: constant `GIT` is never used --> src/api/tools/git/mod.rs:5:11 | 5 | pub const GIT: &str = "git"; | ^^^

warning: methods `get` and `ls` are never used --> src/api/sources/mcman_meta/mod.rs:9:18 | 8 | impl<'a> McmanMetaAPI<'a> { | ------------------------- methods in this implementation 9 | pub async fn get(&self, folder: &str, path: &str) -> Result<String> { | ^^^ ... 16 | pub async fn ls(&self, folder: &str) -> Result<Vec<String>> { | ^^

warning: struct `McmanMetaAPI` is never constructed --> src/api/sources/mcman_meta/mod.rs:6:12 | 6 | pub struct McmanMetaAPI<'a>(pub &'a App); | ^^^^^^^^^^^^

warning: function `resolve_remove_steps` is never used --> src/api/sources/buildtools/mod.rs:29:14 | 29 | pub async fn resolve_remove_steps( | ^^^^^^^^^^^^^^^^^^^^

warning: methods `fetch_versions` and `fetch_version` are never used --> src/api/sources/spigot/mod.rs:35:18 | 21 | impl<'a> SpigotAPI<'a> { | ---------------------- methods in this implementation ... 35 | pub async fn fetch_versions(&self, id: &str) -> Result<Vec<SpigotVersionDetailed>> { | ^^^^^^^^^^^^^^ ... 43 | pub async fn fetch_version(&self, id: &str, version: &str) -> Result<SpigotVersionDetailed> { | ^^^^^^^^^^^^^

warning: methods `fetch_project_versions` and `get_download_url` are never used --> src/api/sources/hangar/mod.rs:22:18 | 13 | impl<'a> HangarAPI<'a> { | ---------------------- methods in this implementation ... 22 | pub async fn fetch_project_versions(&self, id: &str) -> Result<ProjectVersionsResponse> { | ^^^^^^^^^^^^^^^^^^^^^^ ... 30 | pub fn get_download_url(&self, id: &str, version: &str, platform: &str) -> String { | ^^^^^^^^^^^^^^^^

warning: methods `fetch_loaders`, `fetch_versions`, and `fetch_installers` are never used --> src/api/sources/fabric/mod.rs:13:18 | 12 | impl<'a> FabricAPI<'a> { | ---------------------- methods in this implementation 13 | pub async fn fetch_loaders(&self) -> Result<Vec<FabricLoader>> { | ^^^^^^^^^^^^^ ... 17 | pub async fn fetch_versions(&self) -> Result<Vec<FabricVersion>> { | ^^^^^^^^^^^^^^ ... 21 | pub async fn fetch_installers(&self) -> Result<Vec<FabricInstaller>> { | ^^^^^^^^^^^^^^^^

warning: field `0` is never read --> src/api/sources/fabric/mod.rs:10:26 | 10 | pub struct FabricAPI<'a>(pub &'a App); | --------- ^^^^^^^^^^^ | | | field in this struct | help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 10 | pub struct FabricAPI<'a>(()); | ~~

warning: method `find_url` is never used --> src/api/sources/maven/models.rs:43:12 | 42 | impl MavenMetadata { | ------------------ method in this implementation 43 | pub fn find_url(&self, url: &str) -> Option<(String, String)> { | ^^^^^^^^

warning: methods `get_text` and `get_text_all` are never used --> src/api/sources/maven/models.rs:4:8 | 3 | pub trait XMLExt { | ------ methods in this trait 4 | fn get_text(&self, k: &str) -> Result<String>; | ^^^^^^^^ 5 | fn get_text_all(&self, k: &str) -> Vec<String>; | ^^^^^^^^^^^^

warning: methods `find_maven_artifact`, `fetch_metadata`, and `fetch_metadata_url` are never used --> src/api/sources/maven/mod.rs:50:18 | 49 | impl<'a> MavenAPI<'a> { | --------------------- methods in this implementation 50 | pub async fn find_maven_artifact(&self, url: &str) -> Result<MavenMetadata> { | ^^^^^^^^^^^^^^^^^^^ ... 60 | pub async fn fetch_metadata( | ^^^^^^^^^^^^^^ ... 70 | pub async fn fetch_metadata_url(&self, url: &str) -> Result<MavenMetadata> { | ^^^^^^^^^^^^^^^^^^

warning: function `guess_maven_metadata_url` is never used --> src/api/sources/maven/mod.rs:25:8 | 25 | pub fn guess_maven_metadata_url(url: &str) -> Result<String> { | ^^^^^^^^^^^^^^^^^^^^^^^^

warning: function `maven_metadata_url` is never used --> src/api/sources/maven/mod.rs:17:8 | 17 | pub fn maven_metadata_url(url: &str, group_id: &str, artifact_id: &str) -> String { | ^^^^^^^^^^^^^^^^^^

warning: field `0` is never read --> src/api/sources/maven/mod.rs:8:25 | 8 | pub struct MavenAPI<'a>(pub &'a App); | -------- ^^^^^^^^^^^ | | | field in this struct | help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 8 | pub struct MavenAPI<'a>(()); | ~~

warning: method `fetch_versions` is never used --> src/api/sources/papermc/mod.rs:21:18 | 13 | impl<'a> PaperMCAPI<'a> { | ----------------------- method in this implementation ... 21 | pub async fn fetch_versions(&self, project: &str) -> Result<Vec<String>> { | ^^^^^^^^^^^^^^

warning: method `paste_log` is never used --> src/api/sources/mclogs/mod.rs:16:18 | 15 | impl<'a> MCLogsAPI<'a> { | ---------------------- method in this implementation 16 | pub async fn paste_log(&self, content: &str) -> Result<LogFileMetadata> { | ^^^^^^^^^

warning: function `dollar_repl` is never used --> src/api/sources/vanilla/rulematcher.rs:187:4 | 187 | fn dollar_repl<F>(input: &str, replacer: F) -> String | ^^^^^^^^^^^

warning: multiple associated items are never used --> src/api/sources/vanilla/rulematcher.rs:20:12 | 17 | impl PistonRuleMatcher { | ---------------------- associated items in this implementation ... 20 | pub fn new(os_name: String, os_arch: String, os_version: String) -> Self { | ^^^ ... 33 | pub fn empty() -> Self { | ^^^^^ ... 47 | pub fn from_os() -> Self { | ^^^^^^^ ... 71 | pub fn should_download_library(&self, library: &PistonLibrary) -> bool { | ^^^^^^^^^^^^^^^^^^^^^^^ ... 79 | pub fn get_native_library(&self, library: &PistonLibrary) -> Option<PistonFile> { | ^^^^^^^^^^^^^^^^^^ ... 93 | pub fn match_rules(&self, rules: &Vec<PistonRule>) -> bool { | ^^^^^^^^^^^ ... 107 | pub fn match_rule(&self, rule: &PistonRule) -> bool { | ^^^^^^^^^^ ... 117 | pub fn match_constraint(&self, constraint: &PistonRuleConstraints) -> bool { | ^^^^^^^^^^^^^^^^ ... 145 | pub fn build_args( | ^^^^^^^^^^ ... 172 | pub fn process_string(&self, map: &HashMap<String, String>, input: &str) -> String { | ^^^^^^^^^^^^^^

warning: struct `PistonRuleMatcher` is never constructed --> src/api/sources/vanilla/rulematcher.rs:12:12 | 12 | pub struct PistonRuleMatcher { | ^^^^^^^^^^^^^^^^^

warning: method `find` is never used --> src/api/sources/vanilla/manifest.rs:16:12 | 13 | impl VersionManifest { | -------------------- method in this implementation ... 16 | pub fn find(&self, id: &str) -> Option<VersionIndex> { | ^^^^

warning: methods `get_url` and `get_path` are never used --> src/api/sources/vanilla/assets.rs:21:12 | 18 | impl MCAsset { | ------------ methods in this implementation ... 21 | pub fn get_url(&self) -> String { | ^^^^^^^ ... 27 | pub fn get_path(&self) -> String { | ^^^^^^^^

warning: constant `RESOURCES_URL` is never used --> src/api/sources/vanilla/assets.rs:4:11 | 4 | pub const RESOURCES_URL: &str = "https://resources.download.minecraft.net"; | ^^^^^^^^^^^^^

warning: method `fetch_latest_mcver` is never used --> src/api/sources/vanilla/mod.rs:49:18 | 44 | impl<'a> VanillaAPI<'a> { | ----------------------- method in this implementation ... 49 | pub async fn fetch_latest_mcver(&self) -> Result<String> { | ^^^^^^^^^^^^^^^^^^

warning: methods `fetch_versions` and `version_from_hash` are never used --> src/api/sources/modrinth/mod.rs:32:18 | 19 | impl<'a> ModrinthAPI<'a> { | ------------------------ methods in this implementation ... 32 | pub async fn fetch_versions(&self, id: &str) -> Result<Vec<ModrinthVersion>> { | ^^^^^^^^^^^^^^ ... 103 | pub async fn version_from_hash(&self, hash: &str, algo: &str) -> Result<ModrinthVersion> { | ^^^^^^^^^^^^^^^^^

warning: method `fetch_download_url` is never used --> src/api/sources/curseforge/mod.rs:38:18 | 13 | impl<'a> CurseforgeAPI<'a> { | -------------------------- method in this implementation ... 38 | pub async fn fetch_download_url(&self, mod_id: &str, file_id: &str) -> Result<String> { | ^^^^^^^^^^^^^^^^^^

warning: method `get_args` is never used --> src/api/models/launcher/mod.rs:39:12 | 38 | impl ServerLauncher { | ------------------- method in this implementation 39 | pub fn get_args(&self, exec: &str) -> Vec<String> { | ^^^^^^^^

warning: associated functions `all` and `get_markdown_header` are never used --> src/api/models/metadata/addon_metadata.rs:20:12 | 19 | impl AddonMetadataSource { | ------------------------ associated functions in this implementation 20 | pub fn all() -> Vec<Self> { | ^^^ ... 33 | pub fn get_markdown_header() -> String { | ^^^^^^^^^^^^^^^^^^^

warning: method `update` is never used --> src/api/models/server/server_type.rs:150:18 | 101 | impl ServerJar { | -------------- method in this implementation ... 150 | pub async fn update(&mut self, app: &App) -> Result<bool> { | ^^^^^^

warning: methods `supports_datapacks`, `supports_mods`, and `supports_plugins` are never used --> src/api/models/server/server_flavor.rs:15:12 | 14 | impl ServerFlavor { | ----------------- methods in this implementation 15 | pub fn supports_datapacks(&self) -> bool { | ^^^^^^^^^^^^^^^^^^ ... 22 | pub fn supports_mods(&self) -> bool { | ^^^^^^^^^^^^^ ... 29 | pub fn supports_plugins(&self) -> bool { | ^^^^^^^^^^^^^^^^

warning: associated function `from_addon` is never used --> src/api/models/packwiz/mod.rs:52:18 | 50 | impl PackwizMod { | --------------- associated function in this implementation 51 | // TODO: incomplete 52 | pub async fn from_addon(app: &App, addon: &Addon) -> Result<(PathBuf, Self)> { | ^^^^^^^^^^

warning: associated function `from_steps` is never used --> src/api/models/packwiz/mod.rs:45:18 | 44 | impl PackwizModDownload { | ----------------------- associated function in this implementation 45 | pub async fn from_steps(steps: &Vec<Step>) -> Self { | ^^^^^^^^^^

warning: associated function `from_addon_type` is never used --> src/api/models/packwiz/mod.rs:35:12 | 34 | impl PackwizModUpdate { | --------------------- associated function in this implementation 35 | pub fn from_addon_type(addon_type: &AddonType) -> Result<Option<Self>> { | ^^^^^^^^^^^^^^^

warning: enum `LockfileMessage` is never used --> src/api/models/lockfile/mod.rs:28:10 | 28 | pub enum LockfileMessage { | ^^^^^^^^^^^^^^^

warning: method `to_path` is never used --> src/api/models/addon/addon_target.rs:45:12 | 19 | impl AddonTarget { | ---------------- method in this implementation ... 45 | pub fn to_path(&self) -> PathBuf { | ^^^^^^^

warning: methods `source_name`, `accessor`, and `modpack_type` are never used --> src/api/models/source.rs:34:12 | 33 | impl Source { | ----------- methods in this implementation 34 | pub fn source_name(&self) -> &'static str { | ^^^^^^^^^^^ ... 42 | pub fn accessor(&self) -> Result<Accessor> { | ^^^^^^^^ ... 50 | pub fn modpack_type(&self) -> Option<ModpackType> { | ^^^^^^^^^^^^

warning: enum `FileMessage` is never used --> src/api/app/logging/mod.rs:7:10 | 7 | pub enum FileMessage { | ^^^^^^^^^^^

warning: enum `Message` is never used --> src/api/app/logging/mod.rs:3:10 | 3 | pub enum Message { | ^^^^^^^

warning: fields `modrinth`, `mclogs`, and `mcman_meta` are never read --> src/api/app/options/mod.rs:25:9 | 21 | pub struct ApiUrls { | ------- fields in this struct ... 25 | pub modrinth: String, | ^^^^^^^^ ... 35 | pub mclogs: String, | ^^^^^^ ... 39 | pub mcman_meta: String, | ^^^^^^^^^^

warning: field `github_token` is never read --> src/api/app/options/mod.rs:12:9 | 4 | pub struct AppOptions { | ---------- field in this struct ... 12 | pub github_token: Option<String>, | ^^^^^^^^^^^^

warning: method `save_changes` is never used --> src/api/app/io.rs:21:18 | 10 | impl App { | -------- method in this implementation ... 21 | pub async fn save_changes(&self) -> Result<()> { | ^^^^^^^^^^^^

warning: method `reset_lockfile` is never used --> src/api/app/actions/lockfile/mod.rs:8:18 | 7 | impl App { | -------- method in this implementation 8 | pub async fn reset_lockfile(&self) -> Result<()> { | ^^^^^^^^^^^^^^

warning: method `render_addon_metadata` is never used --> src/api/app/actions/markdown/mod.rs:49:18 | 7 | impl App { | -------- method in this implementation ... 49 | pub async fn render_addon_metadata(&self, metadata: Vec<AddonMetadata>) -> Result<String> { | ^^^^^^^^^^^^^^^^^^^^^

warning: method `action_init_network` is never used --> src/api/app/actions/init/mod.rs:46:18 | 10 | impl App { | -------- method in this implementation ... 46 | pub async fn action_init_network(&self) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^

warning: field `ci` is never read --> src/api/app/mod.rs:39:9 | 31 | pub struct App { | --- field in this struct ... 39 | pub ci: bool, | ^^ | = note: `#[warn(dead_code)]` on by default

warning: unreachable pattern --> src/api/models/markdown/render.rs:40:25 | 40 | _ => meta.source.into_str().to_owned(), | ^ | = note: `#[warn(unreachable_patterns)]` on by default

warning: unused import: `Digest` --> src/api/utils/hashing/curseforge.rs:1:14 | 1 | use digest::{Digest, DynDigest, FixedOutput, FixedOutputReset, OutputSizeUser, Reset, Update}; | ^^^^^^

warning: unused variable: `args` --> src/commands/markdown/print.rs:10:33 | 10 | pub async fn run(app: Arc<App>, args: Args) -> Result<()> { | ^^^^ help: if this is intentional, prefix it with an underscore: `_args`

warning: unused variable: `app` --> src/commands/markdown/print.rs:10:18 | 10 | pub async fn run(app: Arc<App>, args: Args) -> Result<()> { | ^^^ help: if this is intentional, prefix it with an underscore: `_app`

warning: unreachable expression --> src/commands/markdown/print.rs:13:5 | 11 | todo!(); | ------- any code following this expression is unreachable 12 | 13 | Ok(()) | ^^^^^^ unreachable expression | = note: `#[warn(unreachable_code)]` on by default

warning: unused variable: `args` --> src/commands/markdown/render.rs:10:33 | 10 | pub async fn run(app: Arc<App>, args: Args) -> Result<()> { | ^^^^ help: if this is intentional, prefix it with an underscore: `_args`

warning: unused variable: `args` --> src/commands/sources/list.rs:10:33 | 10 | pub async fn run(app: Arc<App>, args: Args) -> Result<()> { | ^^^^ help: if this is intentional, prefix it with an underscore: `_args`

warning: unused variable: `args` --> src/commands/init.rs:14:33 | 14 | pub async fn run(app: Arc<App>, args: Args) -> Result<()> { | ^^^^ help: if this is intentional, prefix it with an underscore: `_args`

warning: unused variable: `args` --> src/commands/build.rs:12:33 | 12 | pub async fn run(app: Arc<App>, args: Args) -> Result<()> { | ^^^^ help: if this is intentional, prefix it with an underscore: `_args`

warning: unused variable: `event` --> src/api/ws/mod.rs:84:48 | 84 | pub async fn handle_event(self: Arc<Self>, event: MsgIn) -> Result<()> { | ^^^^^ help: if this is intentional, prefix it with an underscore: `_event`

warning: unused variable: `loader` --> src/api/models/server/server_type.rs:177:33 | 177 | ServerType::Forge { loader } => todo!(), | ^^^^^^ help: try ignoring the field: `loader: _`

warning: unused variable: `loader` --> src/api/models/server/server_type.rs:176:36 | 176 | ServerType::NeoForge { loader } => todo!(), | ^^^^^^ help: try ignoring the field: `loader: _`

warning: unused variable: `installer` --> src/api/models/server/server_type.rs:175:41 | 175 | ServerType::Quilt { loader, installer } => todo!(), | ^^^^^^^^^ help: try ignoring the field: `installer: _`

warning: unused variable: `loader` --> src/api/models/server/server_type.rs:175:33 | 175 | ServerType::Quilt { loader, installer } => todo!(), | ^^^^^^ help: try ignoring the field: `loader: _`

warning: unused variable: `build` --> src/api/models/server/server_type.rs:166:34 | 166 | ServerType::Purpur { build } => todo!(), | ^^^^^ help: try ignoring the field: `build: _`

warning: unused variable: `steps` --> src/api/models/packwiz/mod.rs:53:13 | 53 | let steps = addon.resolve_steps(app).await?; | ^^^^^ help: if this is intentional, prefix it with an underscore: `_steps`

warning: unused variable: `steps` --> src/api/models/packwiz/mod.rs:45:29 | 45 | pub async fn from_steps(steps: &Vec<Step>) -> Self { | ^^^^^ help: if this is intentional, prefix it with an underscore: `_steps`

warning: unused variable: `rendered` --> src/api/app/actions/markdown/mod.rs:59:13 | 59 | let rendered = self.render_metadata(metadata).await?; | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_rendered`

warning: variable does not need to be mutable --> src/api/app/actions/init/mod.rs:51:13 | 51 | let mut nw = Network { name, ..Default::default() }; | ----^^ | | | help: remove this `mut`

warning: unused variable: `nw` --> src/api/app/actions/init/mod.rs:51:17 | 51 | let mut nw = Network { name, ..Default::default() }; | ^^ help: if this is intentional, prefix it with an underscore: `_nw`

warning: variable does not need to be mutable --> src/api/app/actions/init/mod.rs:31:13 | 31 | let mut server = Server { | ----^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

warning: unused variable: `lockfile_entry` --> src/api/app/actions/build/bootstrap.rs:87:13 | 87 | let lockfile_entry = self.existing_lockfile.read().await.as_ref().map(|lock| lock.bootstrapped_files.get(file)).flatten().cloned(); | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_lockfile_entry`

warning: unused variable: `app` --> src/api/models/packwiz/mod.rs:66:36 | 66 | pub async fn into_addon(&self, app: &App, target: AddonTarget) -> Result<Addon> { | ^^^ help: if this is intentional, prefix it with an underscore: `_app`

warning: unused variable: `label` --> src/api/app/step/execute_java.rs:13:9 | 13 | label: &str, | ^^^^^ help: if this is intentional, prefix it with an underscore: `_label`

warning: unused variable: `loader` --> src/api/models/server/server_type.rs:124:33 | 124 | ServerType::Forge { loader } => todo!(), | ^^^^^^ help: try ignoring the field: `loader: _`

warning: unused variable: `loader` --> src/api/models/server/server_type.rs:123:36 | 123 | ServerType::NeoForge { loader } => todo!(), | ^^^^^^ help: try ignoring the field: `loader: _`

warning: unused variable: `build` --> src/api/models/server/server_type.rs:120:34 | 120 | ServerType::Purpur { build } => todo!(), | ^^^^^ help: try ignoring the field: `build: _` | = note: `#[warn(unused_variables)]` on by default

warning: unused import: `path::Path` --> src/commands/init.rs:1:11 | 1 | use std::{path::Path, sync::Arc}; | ^^^^^^^^^^

warning: binding's name is too similar to existing binding --> src/api/utils/pathdiff.rs:77:17 | 77 | let mut itb = base.components(); | ^^^ | note: existing binding defined here --> src/api/utils/pathdiff.rs:76:17 | 76 | let mut ita = path.components(); | ^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names

warning: unused import: `DynDigest` --> src/api/utils/hashing/curseforge.rs:1:22 | 1 | use digest::{Digest, DynDigest, FixedOutput, FixedOutputReset, OutputSizeUser, Reset, Update}; | ^^^^^^^^^

warning: unused imports: `Deserialize`, `Serialize` --> src/api/sources/mcman_meta/mod.rs:2:13 | 2 | use serde::{Deserialize, Serialize}; | ^^^^^^^^^^^ ^^^^^^^^^

warning: unused import: `anyhow` --> src/api/sources/mcman_meta/mod.rs:1:14 | 1 | use anyhow::{anyhow, Result}; | ^^^^^^

warning: unused import: `bail` --> src/api/sources/quilt/mod.rs:1:14 | 1 | use anyhow::{bail, Result}; | ^^^^

warning: unused import: `anyhow::Result` --> src/api/sources/hangar/models.rs:3:5 | 3 | use anyhow::Result; | ^^^^^^^^^^^^^^

warning: unused imports: `assets::*`, `rulematcher::*` --> src/api/sources/vanilla/mod.rs:17:16 | 17 | pub use self::{assets::*, manifest::*, rulematcher::*, version::*}; | ^^^^^^^^^ ^^^^^^^^^^^^^^

warning: unused import: `hook::*` --> src/api/models/legacy/mod.rs:21:9 | 21 | pub use hook::*; | ^^^^^^^

warning: unused import: `network::*` --> src/api/models/legacy/mod.rs:20:9 | 20 | pub use network::*; | ^^^^^^^^^^

warning: unused import: `server_launcher::*` --> src/api/models/legacy/mod.rs:19:9 | 19 | pub use server_launcher::*; | ^^^^^^^^^^^^^^^^^^

warning: unused import: `bail` --> src/api/models/metadata/addon_metadata.rs:1:14 | 1 | use anyhow::{bail, Result}; | ^^^^

warning: unused import: `url::get_filename_from_url` --> src/api/models/packwiz/mod.rs:10:87 | 10 | use crate::api::{app::App, models::AddonType, step::Step, utils::{accessor::Accessor, url::get_filename_from_url}}; | ^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `Path` --> src/api/models/packwiz/mod.rs:4:17 | 4 | use std::path::{Path, PathBuf}; | ^^^^

warning: unused import: `Environment` --> src/api/models/mrpack/mod.rs:13:44 | 13 | use super::{Addon, AddonTarget, AddonType, Environment}; | ^^^^^^^^^^^

warning: unused import: `models::Environment` --> src/api/models/mrpack/mrpack_file.rs:5:18 | 5 | use crate::api::{models::Environment, utils::hashing::HashFormat}; | ^^^^^^^^^^^^^^^^^^^

warning: unused import: `logging::*` --> src/api/app/mod.rs:20:9 | 20 | pub use logging::*; | ^^^^^^^^^^

warning: unused imports: `JavaProcess`, `JavaVersion`, `self` --> src/api/app/step/remove_file.rs:5:66 | 5 | use crate::api::{app::App, step::{FileMeta, StepResult}, tools::{self, java::{JavaProcess, JavaVersion}}}; | ^^^^ ^^^^^^^^^^^ ^^^^^^^^^^^

warning: unused imports: `anyhow`, `bail` --> src/api/app/step/remove_file.rs:3:14 | 3 | use anyhow::{anyhow, bail, Result}; | ^^^^^^ ^^^^

warning: unused import: `anyhow` --> src/api/app/step/download.rs:3:14 | 3 | use anyhow::{anyhow, bail, Context, Result}; | ^^^^^^

warning: redundant else block --> src/api/app/step/cache_check.rs:69:28 | 69 | } else { | ____________________________^ 70 | | // hash mismatch 71 | | // TODO: print warning 72 | | println!("WARNING Hash mismatch: {}", metadata.filename); 73 | | tokio::fs::remove_file(&output_path).await.context("hash mismatch remove file")?; 74 | | } | |_____________________^ | = help: remove the `else` block and move the contents out = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else = note: `-W clippy::redundant-else` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::redundant_else)]`

warning: unused import: `anyhow` --> src/api/app/step/cache_check.rs:3:14 | 3 | use anyhow::{anyhow, Context, Result}; | ^^^^^^

warning: unused import: `lockfile::Lockfile` --> src/api/app/io.rs:6:27 | 6 | use crate::api::{models::{lockfile::Lockfile, network::{Network, NETWORK_TOML}, server::{Server, SERVER_TOML}}, utils::toml::{try_find_to... | ^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: binding's name is too similar to existing binding --> src/api/app/http.rs:22:13 | 22 | let res = req.send().await?.error_for_status()?; | ^^^ | note: existing binding defined here --> src/api/app/http.rs:18:13 | 18 | let req = self.http_client.get(url.as_str()); | ^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names = note: `-W clippy::similar-names` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::similar_names)]`

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/