Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MiniMessage Velocity translations #1108

Open
wants to merge 7 commits into
base: dev/3.0.0
Choose a base branch
from
Open

Implement MiniMessage Velocity translations #1108

wants to merge 7 commits into from

Conversation

4drian3d
Copy link
Contributor

image

resolves #720

@4drian3d 4drian3d mentioned this pull request Oct 13, 2023
Closed
@powercasgamer
Copy link
Contributor

Won't this break existing translations from the lang folder?

@4drian3d
Copy link
Contributor Author

4drian3d commented Nov 4, 2023

Won't this break existing translations from the lang folder?

Yes, I was also thinking of integrating a migration once #1111 is merged

@4drian3d
Copy link
Contributor Author

Won't this break existing translations from the lang folder?

Yes, I was also thinking of integrating a migration once #1111 is merged

Implemented a migration to the new format, this pull request is ready for another review

image

@electronicboy
Copy link
Member

This has my approval, and the prerequisite PR has been pulled, just need to figure out what to do regarding crowdin

@4drian3d 4drian3d added the type: feature New feature or request label Jan 19, 2024
@4drian3d
Merge branch 'dev/3.0.0' into feat/minimessage-translations
9530b94 
# Conflicts:
#	proxy/src/main/java/com/velocitypowered/proxy/connection/client/ConnectedPlayer.java
#	proxy/src/main/java/com/velocitypowered/proxy/provider/ComponentLoggerProviderImpl.java
@4drian3d
Fixed compilation
1b8f3da
@R00tB33rMan
Copy link
Contributor

Only issue I have when testing is that tooltips appear not properly to parse from the messages.properties file properly

@R00tB33rMan
Copy link
Contributor

R00tB33rMan commented Apr 16, 2024 •
edited
Loading

Managed to fix it with these changes. Thought this'd help speed up the state of this PR (ignore the messages.properties changes, except for the Plugins: one:
image
or GemstoneGG/Velocity-CTD@libdeflate@{1day}...libdeflate

@SpaceYoshi
Copy link

SpaceYoshi commented Aug 17, 2024 •
edited
Loading

I just implemented this into my Paper plugin, and noticed that single quotes behave differently using the code in 'VelocityTranslationRegistry' as opposed to using 'TranslationRegistry.create()' directly.
Normally, MessageFormat converts double single quotes '' into '. Now, double single quotes are left unchanged, and a single ' gets removed. Not too big of a deal, but I still wanted to share. Can someone verify this? Notable: MessageFormat.toPattern().

Also: ' and '' are used interchangeably in the property files. Nice addition! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electronicboy electronicboy electronicboy approved these changes

Assignees
No one assigned
Labels
type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HEX/RGB color codes in "com\velocitypowered\proxy\l10n"
5 participants
@4drian3d @powercasgamer @electronicboy @R00tB33rMan @SpaceYoshi