Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies with joining state #1456

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

Pablete1234
Copy link
Member

@Pablete1234 Pablete1234 commented Dec 7, 2024

Fixes a few issues:

  • Dead players joining a diff team weren't passed thru joining state
  • Joining or Dead (with spectate=true) have no obs perms, this is annoying since it means compass doesn't work
  • Joining gets their state reset (inventory cleared, given obs tools, and set in creative!!)
    • Before, ending up in joining state while you were playing in the match meant you kept all inventory state, and you were left in survival mode too
  • Noticed that compass module was created even when no compasses are defined, fixed that too

@Pablete1234 Pablete1234 merged commit 1e2e9f6 into dev Dec 7, 2024
2 checks passed
@Pablete1234 Pablete1234 deleted the fix-dead-transition branch December 7, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants