fix(lib): Generate a module version of the library to be used as import in a devlopment source #46
+59
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ods-charts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jacques-lebourgeois
force-pushed
the
18-building-angular-test-display-the-warning-on-ods-charts-dependency
branch
from
78a8d78
to
5c253eb
Compare
jacques-lebourgeois
changed the title
| @@ -8,7 +8,8 @@ | |||
| "files": [ | |||
| "./dist/**/*" | |||
| ], | |||
| "main": "./dist/ods-charts.js", | |||
There was a problem hiding this comment.
The main file here should remain dist/ods-charts.js because this would be the default packaged version. The module version shouldn't be the default one.
For example, in Bootstrap:
"main": "dist/js/bootstrap.js",
"module": "dist/js/bootstrap.esm.js",There was a problem hiding this comment.
I test this solution (with the changes in webpack.config.js as well of course), and i got back the angular compilation errors :
./src/app/graph/graph.component.ts:44:21-46 - Error: export 'getThemeManager' (imported as 'ODSCharts') was not found in 'ods-charts' (module has no exports)
./src/app/graph/graph.component.ts:45:14-43 - Error: export 'ODSChartsMode' (imported as 'ODSCharts') was not found in 'ods-charts' (module has no exports)
./src/app/graph/graph.component.ts:46:27-79 - Error: export 'ODSChartsCategoricalColorsSet' (imported as 'ODSCharts') was not found in 'ods-charts' (module has no exports)
./src/app/graph/graph.component.ts:47:24-78 - Error: export 'ODSChartsSequentialColorsSet' (imported as 'ODSCharts') was not found in 'ods-charts' (module has no exports)
./src/app/graph/graph.component.ts:48:19-54 - Error: export 'ODSChartsLineStyle' (imported as 'ODSCharts') was not found in 'ods-charts' (module has no exports)
NB : to update the angular projet before testing, I do
npm uninstall ods-charts
npm i ../..
webpack.config.js
Outdated
| ...defaultConfig, | ||
| output: { | ||
| path: path.resolve(__dirname, './dist'), | ||
| filename: 'ods-charts-module.js', |
There was a problem hiding this comment.
Usually, the naming convention used by libraries is the following:
ods-charts.jsods-charts.esm.jsods-charts.umd.js
And for the minified versions:
ods-charts.min.jsods-charts.esm.min.jsods-charts.umd.min.js
jacques-lebourgeois
force-pushed
the
18-building-angular-test-display-the-warning-on-ods-charts-dependency
branch
from
5c253eb
to
d1459eb
Compare
jacques-lebourgeois
force-pushed
the
18-building-angular-test-display-the-warning-on-ods-charts-dependency
branch
from
4d9ff7f
to
4c5dc98
Compare
I just made a rebase |
|
Oh ! I think it worked but react test is broken ! :( |
…rt in a devlopment source
jacques-lebourgeois
force-pushed
the
18-building-angular-test-display-the-warning-on-ods-charts-dependency
branch
from
4c5dc98
to
e21dbc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#18
Description
Angular compilation gave a warning on CommonJS or AMD dependencies
To get code generation optimized, it is recommended that you use ECMAScript modules.
The Pull request contains:
Motivation & Context
Code optimization
Types of change
Test checklist
Please check that the following tests projects are still working:
docs/examplestest/angular-ngx-echartstest/angular-tour-of-heroestest/htmltest/reacttest/vuetest/examples/bar-line-charttest/examples/single-line-chart