Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
Closes #2504.
Description
Changes and aligns all the
.display-*
,h*
,.lead
,small
and introduces.body-*
and.label-*
.Removes
.display-4
since it was never used here.Kept
h4/5/6
for consistency.h4/5/6
or set them asTitle small
?.lead
,.small
, etc ... to provide the styles ? It seems quite hard since we have many body and label styles.Remaining things to do:
h1
on mobile depends onh2
desktop or.body-lg
depends on theh5
desktop font-size. Could be great to undupe all this, use clear variables and multiples but it could be quite heavyMotivation & Context
UI Kit v6 changes many things regarding font sizes.
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge