Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Migrate from PCCR@V1 to ReportGenerator #2262

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

dl3sdo
Copy link
Member

@dl3sdo dl3sdo commented Jul 23, 2024

Although the current V1 version of the publish code coverage results task is still available it's recommended to stop using the V1 version and migrate to V2 version.

Although the current V1 version of the publish code coverage results
task is still available it's recommended to stop using the V1 version
and migrate to V2 version.
@dl3sdo
Copy link
Member Author

dl3sdo commented Jul 23, 2024

There seems to be a dispute about migrating to V2:
New version of Publish Code Coverage Results task
See also:
https://github.com/danielpalme/ReportGenerator/wiki/Integration

@dg0yt
Copy link
Member

dg0yt commented Jul 28, 2024

So V2 doesn't offer click-through to the sources.
Do really want to upgrade?
Does danielpalme/ReportGenerator#646 (comment) provide an alternative?

@dl3sdo
Copy link
Member Author

dl3sdo commented Jul 28, 2024

As there is currently nothing that forces us to move to V2 let's give the alternative solution a try, otherwise let's continue with V1.
@dg0yt: do you have to install the ReportGenerator extension from the Marketplace first?

@dl3sdo
Copy link
Member Author

dl3sdo commented Jul 28, 2024

/azp run

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@dg0yt
Copy link
Member

dg0yt commented Jul 29, 2024

I added the ReportGenerator from the AZP marketplace. I couldn't re-run the failed job, but I could start a new run for the same merge commit.

@dl3sdo
Copy link
Member Author

dl3sdo commented Jul 29, 2024

Seems to work now. Before: https://dev.azure.com/OpenOrienteering/Mapper/_build/results?buildId=2903&view=codecoverage-tab After: https://dev.azure.com/OpenOrienteering/Mapper/_build/results?buildId=2907&view=codecoverage-tab

For me it looks rather that one report is V1 and one report is V2 but none of them is Daniel Palme's report.

@dg0yt
Copy link
Member

dg0yt commented Jul 29, 2024

AFAIU V1 uses an old version of that ReportGenerator, so similarities are expected.
And you can check the steps run for the coverage pipeline.

In fact, the version is reported in the footer.
Before: ReportGenerator 5.2.2.0
After: ReportGenerator 5.3.8.0

@dg0yt
Copy link
Member

dg0yt commented Jul 29, 2024

Copy link
Member

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dg0yt dg0yt changed the title CI: Move to V2 version of the PCCR task CI: Migrate from PublishCodeCoverResults@V1 to ReportGenerator Jul 29, 2024
@dg0yt dg0yt changed the title CI: Migrate from PublishCodeCoverResults@V1 to ReportGenerator CI: Migrate from PCCR@V1 to ReportGenerator Jul 29, 2024
@dg0yt
Copy link
Member

dg0yt commented Jul 29, 2024

Close/Re-open to reset state.

@dg0yt dg0yt closed this Jul 29, 2024
@dg0yt dg0yt reopened this Jul 29, 2024
@dg0yt dg0yt merged commit c9fb398 into OpenOrienteering:master Jul 29, 2024
12 checks passed
@dg0yt
Copy link
Member

dg0yt commented Jul 29, 2024

Thanks.

@dl3sdo dl3sdo deleted the publish-code-coverage branch July 29, 2024 23:00
@dg0yt
Copy link
Member

dg0yt commented Jul 30, 2024

This PR was meant to be squashed when merged... I will force-push master.
CC @dl3sdo @lpechacek.

dg0yt pushed a commit that referenced this pull request Jul 30, 2024
Version 1 of the PublishCodeCoverageResults task is deprecated.
Version 2 has known limitations. Switching to ReportGenerator
is a better alternative at the moment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants