-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Migrate from PCCR@V1 to ReportGenerator #2262
Conversation
Although the current V1 version of the publish code coverage results task is still available it's recommended to stop using the V1 version and migrate to V2 version.
There seems to be a dispute about migrating to V2: |
So V2 doesn't offer click-through to the sources. |
As there is currently nothing that forces us to move to V2 let's give the alternative solution a try, otherwise let's continue with V1. |
/azp run |
Azure Pipelines failed to run 1 pipeline(s). |
I added the ReportGenerator from the AZP marketplace. I couldn't re-run the failed job, but I could start a new run for the same merge commit. |
For me it looks rather that one report is V1 and one report is V2 but none of them is Daniel Palme's report. |
AFAIU V1 uses an old version of that ReportGenerator, so similarities are expected. In fact, the version is reported in the footer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Close/Re-open to reset state. |
Thanks. |
This PR was meant to be squashed when merged... I will force-push master. |
Version 1 of the PublishCodeCoverageResults task is deprecated. Version 2 has known limitations. Switching to ReportGenerator is a better alternative at the moment.
Although the current V1 version of the publish code coverage results task is still available it's recommended to stop using the V1 version and migrate to V2 version.