Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mojatax: Implement post and generic request function #787

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

hunterachieng
Copy link
Contributor

@hunterachieng hunterachieng commented Oct 15, 2024

Summary

This is the implementation of a new adaptor mojatax

Fixes #773

Details

A new basic adaptor mojatax has been created with a simple post function to create an invoice and a generic request function for any other HTTP methods

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Copy link
Collaborator

@josephjclark josephjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple Hunter! Just a couple of little comments

packages/mojatax/src/Adaptor.js Show resolved Hide resolved
packages/mojatax/src/Utils.js Outdated Show resolved Hide resolved
packages/mojatax/src/Utils.js Outdated Show resolved Hide resolved
packages/mojatax/src/Utils.js Outdated Show resolved Hide resolved
packages/mojatax/src/Utils.js Outdated Show resolved Hide resolved
packages/mojatax/test/Adaptor.test.js Outdated Show resolved Hide resolved
packages/mojatax/test/Adaptor.test.js Outdated Show resolved Hide resolved
packages/mojatax/test/Adaptor.test.js Show resolved Hide resolved
@josephjclark josephjclark merged commit c2db522 into main Oct 16, 2024
2 checks passed
@josephjclark josephjclark deleted the feat/mojatax-adaptor branch October 16, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

mojatax new adaptor
2 participants