Implement replacetextEx_char, reimplement Splittext to match new 515 behavior #1921
+197
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
Compiler
|
Drafting due to a new test I added failing, going to resolve that (Empty strings should be splitting on every char, but instead dont split at all) |
|
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Maybe mark as draft if it's not ready for merge |
|
Yeah these haven't been worked on for a while, I'm not sure if I'll be able to get to them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple one-liner piggybacking off jointext and spltitext, with an update to Splittext so that it functions properly.
Basically, splittext has been updated in 515 to include the start and end of the string, so the current implementation of Splittext now remembers that and pre/appends those parts to the first/last elements.
The splittext unit tests were updated based off the output from DM for 515:
Originally this was just going to be a one-liner for replacetextEx_char, but after being informed of the changes needed to Splittext I decided to go ahead and do that too, so that this works.