Make iPhoneDeploymentTarget configurable via plugin props
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: * we aren't using iOSBundleIdentifier at all * add `iPhoneDeploymentTarget` to add ability to configure the target via plugin props
Motivation: instead of continuing to pass in more and more arguments into the `xcodeProjectAddNSE` function. We can package them instead into `PluginOptions` and pass it as a single arg.
Motivation: we set the NSE target `IPHONEOS_DEPLOYMENT_TARGET` value to the value passed in via plugin props. If undefined, we fallback via `??` to the default `IPHONEOS_DEPLOYMENT_TARGET`.
Motivation: with 3 plugin "props" it's better to include in a table. * since "devTeam" is optional, it's better to not include it in the example. * Update the version icon to beta 9
jkasten2
requested changes
Jan 10, 2022
jkasten2
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 line description
Adds the ability to configure the iOS Deployment Target via the Expo plugin props.
Details
As noted in #40 , there is a version mismatch causing problems when attempting to create the Notification Service Extension which was previously hard-set to "10.0". If the project Podfile is set "12.0" for example, the value used by the NSE target should match. These changes introduce a new plugin "prop" that makes this value configurable.