fix: update docker samples to use az acr build (#1365)

OfficeDev · Nov 21, 2024 · f441ccc · f441ccc
1 parent 8c4f02b
commit f441ccc
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/bot-sso-docker/README.md b/bot-sso-docker/README.md
@@ -47,7 +47,7 @@ This sample demonstrate how to containerize a Teams App and integrate the Docker
 
 - **Provision Infrastructure**: Automate the provisioning of Azure Container Apps and Azure Container Registry using Bicep templates. Refer to this [Azure Bicep example](./infra/azure.bicep).
 
-- **Build and Deploy to ACA**: Build the Docker image and push it to Azure Container Registry using Docker CLI. Deploy the image to Azure Container Apps using Azure CLI. Refer to the deployment scripts in this [teamsapp.yml example](./teamsapp.yml).
+- **Build and Deploy to ACA**: Using Azure CLI, build and push the Docker image to Azure Container Registry, then deploy it to Azure Container Apps. Refer to the deployment scripts in this [teamsapp.yml example](./teamsapp.yml).
 
 ## Minimal path to awesome
 

diff --git a/bot-sso-docker/teamsapp.yml b/bot-sso-docker/teamsapp.yml
@@ -77,20 +77,15 @@ deploy:
       run: echo "::set-teamsfx-env
         AZURE_CONTAINER_IMAGE=${{AZURE_CONTAINER_REGISTRY_SERVER}}/sso-bot"
 
-  - uses: script
-    name: build container image
-    with:
-      run: docker build -t ${{AZURE_CONTAINER_IMAGE}} .
-
   - uses: script
     name: login azure container registry
     with:
       run: az acr login -n ${{AZURE_CONTAINER_REGISTRY_NAME}}
 
-  - uses: script
-    name: push container image
-    with:
-      run: docker push ${{AZURE_CONTAINER_IMAGE}}
+  - uses: script  
+    name: build container image
+    with:  
+      run: az acr build --registry ${{AZURE_CONTAINER_REGISTRY_NAME}} --image ${{AZURE_CONTAINER_IMAGE}} .
 
   - uses: script
     name: deploy container image

diff --git a/hello-world-tab-docker/README.md b/hello-world-tab-docker/README.md
@@ -57,7 +57,7 @@ This sample demonstrate how to containerize a Teams App and integrate the Docker
 
 - **Provision Infrastructure**: Automate the provisioning of Azure Container Apps and Azure Container Registry using Bicep templates. Refer to this [Azure Bicep example](./infra/azure.bicep).
 
-- **Build and Deploy to ACA**: Build the Docker image and push it to Azure Container Registry using Docker CLI. Deploy the image to Azure Container Apps using Azure CLI. Refer to the deployment scripts in this [teamsapp.yml example](./teamsapp.yml).
+- **Build and Deploy to ACA**: Using Azure CLI, build and push the Docker image to Azure Container Registry, then deploy it to Azure Container Apps. Refer to the deployment scripts in this [teamsapp.yml example](./teamsapp.yml).
 
 ## Minimal path to awesome