Improve error message and merge heuristic #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#get-a-pull-request, `mergeable` may be `null` if the background checks to compute mergability are not finished running. Improve the error message for this edge case.
hyperupcall
changed the title
|
👍🏻 this all seems very reasonable to me, nice work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again!
I came across two bugs in
code-owner-self-merge:This PR fixes those errors. These changes have been active at
SchemaStore/schemastorefor a week, and things seem to work as expected.Related to 8714b49 and #34.