Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nav.about.teams: Create Team page and add to the About nav dropdow #415

Merged
merged 33 commits into from
Mar 22, 2024

Conversation

cwhite911
Copy link
Contributor

@cwhite911 cwhite911 commented Mar 13, 2024

About Us > Team (Issue: #414 )

I added Team to the About Us nav dropdown and started working on the team page. I also changed the nav title from About to About Us and moved it to the first item on the navbar.

TODO:

  • Add maintainers (Move to another PR)
  • Fix CSS issue with team layout
  • Get approved images from everyone.
  • Edit descriptive text

PSC Description:

Screenshot 2024-03-13 at 18-22-00 GRASS GIS - Bringing advanced geospatial technologies to the world

PSC Chair:

Screenshot 2024-03-13 at 18-22-19 GRASS GIS - Bringing advanced geospatial technologies to the world

PSC Members:

Screenshot 2024-03-13 at 18-22-43 GRASS GIS - Bringing advanced geospatial technologies to the world

@cwhite911 cwhite911 mentioned this pull request Mar 13, 2024
39 tasks
@echoix
Copy link
Member

echoix commented Mar 14, 2024

Do you know if the site builder rerasterises/crops the pictures to not have to load a multimegabyte image that will not be fully displayed and bigger than necessary?

@neteler
Copy link
Member

neteler commented Mar 14, 2024

Do you know if the site builder rerasterises/crops the pictures to not have to load a multimegabyte image that will not be fully displayed and bigger than necessary?

Generally, there seems to be some magic available in hugo: https://gohugo.io/content-management/image-processing/

@cwhite911
Copy link
Contributor Author

cwhite911 commented Mar 14, 2024

I've finished the setting up the images so that they are resized and filled dynamically. I also added in social info and rearranged the layout.

Screenshot 2024-03-14 at 12-14-41 GRASS GIS - Bringing advanced geospatial technologies to the world

@cwhite911
Copy link
Contributor Author

Updated layout

Screenshot 2024-03-14 at 12-24-03 GRASS GIS - Bringing advanced geospatial technologies to the world

@echoix
Copy link
Member

echoix commented Mar 14, 2024

Would you all be wanting to have the website-in-progress be targeted at a different branch, and that branch be deployed with github-pages? Or have it written so it could work on one of your forks..

@cwhite911
Copy link
Contributor Author

cwhite911 commented Mar 14, 2024

This layout is ready for review.

PSC members please complete the following tasks:

  1. Add your photo to themes/grass/assets/images/team/<FirstName_LastName_PSC>.(png|jpg|webp)
  2. Update your record in data/team.yml with the proper image name. The only thing that may need to change is the file type.
  3. Make sure the social accounts you want link are linked and please double check the existing links are correct.

Example record from data/team.yml

- name: Markus Neteler
    chair: former
    terms: 2006 - 2012, 2012 - 2016, 2016 - 2020
    psc: true
    image: /images/team/Markus_Neteler_PSC.jpg  # Check here
    website: https://www.mundialis.de/
    job: mundialis, Bonn, DE
    country: Germany
    social:  # Add, Remove, and Update Social                                                                   
      - icon: fa fa-envelope
        link: mailto:[email protected] # Check here
      - icon: fab fa-github
        link: https://github.com/neteler # Check here
      - icon: fab fa-linkedin
        link: https://www.linkedin.com/in/markusneteler/  # Check here
      - icon: fab fa-x-twitter
        link: https://twitter.com/MarkusNeteler # Check here
      - icon: fab fa-mastodon
        link: https://mastodon.social/@neteler # Check here

@veroandreo please look at the chair section. I added the bio for you from the SMathHacks event.

The learn more about the PSC section could also be part of the Governance page. That is also where we can include other information from https://trac.osgeo.org/grass/wiki/PSC.

@cwhite911
Copy link
Contributor Author

Would you all be wanting to have the website-in-progress be targeted at a different branch, and that branch be deployed with github-pages? Or have it written so it could work on one of your forks..

I'm not sure. Either works from my perspective, but I am happy to do whatever has worked for the project in the past.

@cwhite911 cwhite911 marked this pull request as ready for review March 14, 2024 16:44
@echoix
Copy link
Member

echoix commented Mar 14, 2024

Would you all be wanting to have the website-in-progress be targeted at a different branch, and that branch be deployed with github-pages? Or have it written so it could work on one of your forks..

I'm not sure. Either works from my perspective, but I am happy to do whatever has worked for the project in the past.

I'm suggesting it because of the type of refactoring that is done, but I know I won't have time this weekend to do it, even if it isn't really complicated.

Copy link
Contributor

@veroandreo veroandreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the layout. I just cut my description a bit (maybe not needed at all), I feel a bit like an impostor being highlighted there 🤦

I'd move the images into static/images/team, because I don't feel we as team are part of the theme :)

data/team.yml Outdated Show resolved Hide resolved
data/team.yml Outdated Show resolved Hide resolved
data/team.yml Show resolved Hide resolved
themes/grass/layouts/about/team.html Outdated Show resolved Hide resolved
themes/grass/layouts/about/team.html Outdated Show resolved Hide resolved
Corey White and others added 7 commits March 14, 2024 17:37
Co-authored-by: Veronica Andreo <[email protected]>
Co-authored-by: Veronica Andreo <[email protected]>
Added mastodon

Co-authored-by: Veronica Andreo <[email protected]>
fixed typo

Co-authored-by: Veronica Andreo <[email protected]>
Removed SVN

Co-authored-by: Veronica Andreo <[email protected]>
@cwhite911
Copy link
Contributor Author

cwhite911 commented Mar 14, 2024

@echoix let's go with publishing a website-in-progress branch to gh-pages.

I like the layout. I just cut my description a bit (maybe not needed at all), I feel a bit like an impostor being highlighted there 🤦

lol @veroandreo you are really going to like that I add Dr. Verónica Andreo. It's the right place to 💪

I'd move the images into static/images/team, because I don't feel we as team are part of the theme :)

The files shouldn't be in static folder because the images are getting processed during the build process. I can look at Hugos docs to see if we can add another assets folder outside of the theme directory.

@echoix
Copy link
Member

echoix commented Mar 14, 2024

So I've got it working (on my branch): https://echoix.github.io/grass-website/

I made it so that we'd need to target all the PRs for the new website on branch "preview" instead of "master", so the existing website won't be broken. So while developing the new website, you could merge to the "preview" branch without problems.

@cwhite911
Copy link
Contributor Author

My other thought was adding a dropdown selector to pick the period you are interested in but that is probably overkill.

Here is the page as it stands now.

Screenshot 2024-03-15 at 14-40-00 GRASS GIS - Bringing advanced geospatial technologies to the world

@neteler
Copy link
Member

neteler commented Mar 16, 2024

We can do this I just need to know who was part of the the PSC for each period.

I have completed the records here: https://trac.osgeo.org/grass/wiki/PSC#FormerPSCmembers

@petrasovaa
Copy link
Contributor

Tracking periods here seems like little too much, but perhaps okay. However, having the former members with all the details definitely seems like too much. Names only? With images, but on a separate page?

I would merge all former members under "Former members" and exclude the current, right now Markus is there as former member which is confusing. I would link the wiki page with all the details.

@cwhite911
Copy link
Contributor Author

Screenshot 2024-03-19 at 14-18-26 GRASS GIS - Bringing advanced geospatial technologies to the world

@cwhite911
Copy link
Contributor Author

I believe this PR is ready to merge.

data/team.yml Outdated Show resolved Hide resolved
data/team.yml Outdated Show resolved Hide resolved
data/team.yml Outdated Show resolved Hide resolved
@petrasovaa petrasovaa merged commit 951c4bc into OSGeo:master Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants