Reload templates without restarting #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
==========================================
- Coverage 96.26% 96.21% -0.06%
==========================================
Files 36 36
Lines 1768 1770 +2
==========================================
+ Hits 1702 1703 +1
- Misses 66 67 +1
Continue to review full report at Codecov.
|
benjefferies
approved these changes
Jun 13, 2018
jcox-dev
approved these changes
Jun 13, 2018
config.py
Outdated
| @@ -104,6 +104,9 @@ class DevelopmentConfig(Config): | |||
| SURVEY_PASSWORD = os.getenv('SURVEY_PASSWORD', 'secret') | |||
| SURVEY_AUTH = (SURVEY_USERNAME, SURVEY_PASSWORD) | |||
|
|
|||
| TEMPLATES_AUTO_RELOAD = True | |||
| EXPLAIN_TEMPLATE_LOADING = True | |||
There was a problem hiding this comment.
Do we want EXPLAIN_TEMPLATE_LOADING on by default? It does tend to flood logs.
There was a problem hiding this comment.
Hmm, good point. It can be useful if there are issues around template loading. I'll conduct a straw poll tomorrow and see what people prefer.
There was a problem hiding this comment.
Is TEMPLATES_AUTO_RELOAD needed? See pallets/flask#1907 and pyvec/elsa#44
jcox-dev
approved these changes
Jun 14, 2018
| @@ -7,7 +7,7 @@ url = "https://pypi.python.org/simple" | |||
| python_version = "3.6" | |||
|
|
|||
| [packages] | |||
| Flask = "==0.12.2" | |||
| Flask = "==0.12" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Autoreloads templates when running debug mode. Developers will see changes to html templates without having to restart a running server.
What has changed
Added new config to config.py to set auto reloading to true and to enable more verbose output of template loading information.
How to test?