fix: NM is reconstructable false

platform/core/src/utils/combineFrameInstance.ts

@@ -1,4 +1,5 @@
 import { vec3 } from 'gl-matrix';
+import { dicomSplit } from './dicomSplit';
 
 /**
  * Combine the Per instance frame data, the shared frame data
@@ -16,23 +17,13 @@ const combineFrameInstance = (frame, instance) => {
     SharedFunctionalGroupsSequence,
     NumberOfFrames,
     SpacingBetweenSlices,
+    ImageType,
   } = instance;
 
+  instance.ImageType = dicomSplit(ImageType);
+
   if (PerFrameFunctionalGroupsSequence || NumberOfFrames > 1) {
     const frameNumber = Number.parseInt(frame || 1);
-    const shared = SharedFunctionalGroupsSequence
-      ? Object.values(SharedFunctionalGroupsSequence[0])
-          .filter(Boolean)
-          .map(it => it[0])
-          .filter(it => typeof it === 'object')
-      : [];
-
-    const perFrame = PerFrameFunctionalGroupsSequence
-      ? Object.values(PerFrameFunctionalGroupsSequence[frameNumber - 1])
-          .filter(Boolean)
-          .map(it => it[0])
-          .filter(it => typeof it === 'object')
-      : [];
 
     // this is to fix NM multiframe datasets with position and orientation
     // information inside DetectorInformationSequence
@@ -73,8 +64,11 @@ const combineFrameInstance = (frame, instance) => {
         ImagePositionPatientToUse = [position[0], position[1], position[2]];
       }
     }
-    const sharedInstance = createCombinedValue(instance, shared);
-    const newInstance = createCombinedValue(sharedInstance, perFrame);
+    const sharedInstance = createCombinedValue(instance, SharedFunctionalGroupsSequence?.[0]);
+    const newInstance = createCombinedValue(
+      sharedInstance,
+      PerFrameFunctionalGroupsSequence?.[frameNumber]
+    );
     newInstance.ImagePositionPatient = ImagePositionPatientToUse ??
       newInstance.ImagePositionPatient ?? [0, 0, frameNumber];
     newInstance.frameNumber = frameNumber;
@@ -84,11 +78,20 @@ const combineFrameInstance = (frame, instance) => {
   }
 };
 
-function createCombinedValue(parent, shared) {
-  if (shared._sharedValue) {
-    return shared._sharedValue;
-  }
+function createCombinedValue(parent, functionalGroups) {
   const newInstance = Object.create(parent);
+  if (!functionalGroups) {
+    return newInstance;
+  }
+  if (functionalGroups._sharedValue) {
+    return functionalGroups._sharedValue;
+  }
+  const shared = functionalGroups
+    ? Object.values(functionalGroups)
+        .filter(Boolean)
+        .map(it => it[0])
+        .filter(it => typeof it === 'object')
+    : [];
 
   // merge the shared first then the per frame to override
   [...shared].forEach(item => {
@@ -100,7 +103,7 @@ function createCombinedValue(parent, shared) {
       newInstance[key] = value;
     });
   });
-  Object.defineProperty(shared, '_sharedValue', {
+  Object.defineProperty(functionalGroups, '_sharedValue', {
     value: newInstance,
     writable: false,
     enumerable: false,

platform/core/src/utils/dicomSplit.ts

@@ -0,0 +1,5 @@
+export function dicomSplit(value) {
+  return (
+    (Array.isArray(value) && value) || (typeof value === 'string' && value.split('\\')) || value
+  );
+}