[16.0][MIG] partner_noncommercial: Migration to 16.0 #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ENH] Migration of the 7.0 module partner_noncommercial. This used to be part of therp-oe-staging modules, but seems to be usefull for more organisations that are primarily or completely non-commercial. The organisations might be put of by the commercial lingo that is shown by default. * [FIX] Add name / mail to contributors.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-11.0/partner-contact-11.0-partner_noncommercial Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-partner_noncommercial/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-12.0/partner-contact-12.0-partner_noncommercial Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_noncommercial/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-12.0/partner-contact-12.0-partner_noncommercial Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_noncommercial/
- Remove All Partners action and menu entry as this duplicates default contact view; - Add some commonly used groupings and filters.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-12.0/partner-contact-12.0-partner_noncommercial Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_noncommercial/
| @@ -0,0 +1,3 @@ | |||
| To configure this module, you need to: | |||
|
|
|||
| #. This module requires no special configuration. | |||
There was a problem hiding this comment.
I think this file can be removed.
ntsirintanis
force-pushed
the
16.0-mig-partner_noncommercial
branch
from
3c27344
to
9f723a5
Compare
thomaspaulb
suggested changes
Nov 27, 2024
| <filter | ||
| name="group_organisation" | ||
| string="Organisation" | ||
| context="{'group_by': 'commercial_partner_id'}" |
There was a problem hiding this comment.
There is already an Odoo default grouping by Company:
<filter name="group_company" string="Company" context="{'group_by': 'parent_id'}"/>
Wouldn't it be better to just change the string of that one?
| <attribute name="string">Organisations</attribute> | ||
| </filter> | ||
|
|
||
| <!-- Add extra filters. --> |
There was a problem hiding this comment.
Odoo also has a filter where you can type a company name and then search for it:
<field name="parent_id" domain="[('is_company', '=', True)]" operator="child_of"/>
Maybe we should also rename that one to Organisation.
thomaspaulb
reviewed
Nov 27, 2024
| <!-- Add extra groupings. --> | ||
| <!-- Change string of Company group to Organisations. --> | ||
| <filter name="group_company" position="attributes"> | ||
| <attribute name="string">Organisations</attribute> |
There was a problem hiding this comment.
singular form seems more appropriate here
thomaspaulb
reviewed
Nov 27, 2024
| @@ -7,6 +7,11 @@ | |||
| <field name="mode">extension</field> | |||
| <field type="xml" name="arch"> | |||
|
|
|||
| <!-- Change string of parent_id field to Organisations. --> | |||
| <field name="parent_id" position="attributes"> | |||
| <attribute name="string">Organisations</attribute> | |||
ntsirintanis
force-pushed
the
16.0-mig-partner_noncommercial
branch
from
627b0e1
to
e7e74bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.