[18.0][MIG] partner_email_check: Migration to 18.0 #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new module partner-email-check Validate email input
…validate_email in partner_email_check
- partner_email_check now uses email-validator instead of validate_email - Email addresses are normalized - There is a setting to enforce uniqueness of partner email addresses - There is a setting to check whether emails are deliverable (i.e. whether the domain resolves)
portal's tests set an invalid email address, `c@c`, that's rejected by the current version of partner_email_check. If partner_email_check is installed before portal's tests run then they fail. To solve this, skip email validation if tests are running, unless a key in the context is set to make the checks run anyway. That lets tests in other addons opt in to the checks as well. The previous update to partner_email_check didn't bump the version number, so do that now.
[REF] Partner email chack params on company [IMP] email_check [IMP] test partner_email_check use SavepointCase
Currently translated at 90.4% (19 of 21 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_email_check Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_email_check/fr/
Currently translated at 42.8% (9 of 21 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_email_check Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_email_check/it/
Currently translated at 100.0% (21 of 21 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_email_check Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_email_check/it/
Currently translated at 100.0% (21 of 21 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_email_check Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_email_check/it/
Currently translated at 100.0% (21 of 21 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_email_check Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_email_check/it/
Currently translated at 100.0% (19 of 19 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_email_check Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_email_check/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-17.0/partner-contact-17.0-partner_email_check Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-partner_email_check/
Currently translated at 100.0% (19 of 19 strings) Translation: partner-contact-17.0/partner-contact-17.0-partner_email_check Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-partner_email_check/it/
The res_config_settings_view_form in Odoo 17 has changed its xml style, and the view_general_configuration in this module was written using Odoo 16 styling. So we need to update it accordingly.
sebalix
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add 1 PR: OCA#1854
to update
res_config_settings_view_formandview_general_configuration