[14.0][IMP] l10n_br_fiscal_edi: add _document_qrcode() on _exec_before_SITUACAO_EDOC_A_ENVIAR method #3508
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ACAO_EDOC_A_ENVIAR method
marcelsavegnago
requested review from
rvalyi,
antoniospneto,
renatonlima and
mileo
rvalyi
requested changes
Nov 27, 2024
There was a problem hiding this comment.
parece OK, mas me parece que a montagem do qrcode da NFCe deveria ser unificado com esse API. ver https://github.com/OCA/l10n-brazil/blob/14.0/l10n_br_nfe/models/document.py#L1227
Tou errado?
Sim.. estava pensando nisso agora pouco.. vou ajustar nesta PR para o NFCe usar este document_qrcode |
marcelsavegnago
force-pushed
the
l10n_br_fiscal_edi-imp-add-documnet_qrcode-to-workflow
branch
from
b294aa9
to
69115ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incluindo a chamada ao metodo generico para geração do qrcode no workflow