Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] document_page_approval: Migration to 17.0 #509

Merged
merged 44 commits into from
Nov 13, 2024
Merged

[17.0][MIG] document_page_approval: Migration to 17.0 #509

merged 44 commits into from
Nov 13, 2024

Commits on Nov 12, 2024

  1. create document_page_approval module 

    (../7.0pageapproval/ rev 1)

fix status bar in page approval
(../7.0pageapproval/ rev 2)

change approval workflow in page history and started to add showing approved page in normal page
(../7.0pageapproval/ rev 3)

show last approved content and aproved by
(../7.0pageapproval/ rev 4)

Fix bug on page creation
(../7.0pageapproval/ rev 5)

add status in history tree view
(../7.0pageapproval/ rev 6)

add a need approval field and hide the workflow when no approval needed
(../7.0pageapproval/ rev 7)

add access validation to approval
(../7.0pageapproval/ rev 8)

give rigth to Page aprover group on the page_history model and hide the button for unallowed group thought the security isn't enforced a the orm level
(../7.0pageapproval/ rev 9)

made invisible the prover group when not needed
(../7.0pageapproval/ rev 10)

add email to aprovers group's members
(../7.0pageapproval/ rev 11)
    @cloutierjo @victoralmau
    cloutierjo authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    7844730 View commit details
    Browse the repository at this point in the history

  2. [IMP] Documentation 

    [ADD] Translation file + french
[FIX] employee_id field does not exist
[FIX] user_email field deprecated
[IMP] Split long lines
[ADD] Images
    @victoralmau
    Maxime Chambreuil authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    75b25fa View commit details
    Browse the repository at this point in the history

  3. Set document_page_approval as unported

    @victoralmau
    Sandy Carter authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    df5c849 View commit details
    Browse the repository at this point in the history

  4. start porting 

    fix act_draft and minor ui fix

remove unused variables

change order of xml data files
    @gborelli @victoralmau
    gborelli authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    1b562a6 View commit details
    Browse the repository at this point in the history

  5. Comment workflow that cause the error 

    It should work but further errors could help understand what's going

Commented other necessary part

Add back workflow

Add dependency to knowledge
    @llacroix @victoralmau
    llacroix authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    e110881 View commit details
    Browse the repository at this point in the history

  6. [IMP] - Changed string from email template. 

    [IMP] - Improved views to match document_page improvements.
[IMP] - Added notification to followers when a new version is approved.
[ADD] - Updated document_page_approval pot and added es translations.
[IMP] - document_page_approval: Updated spanish translation.
    @victoralmau
    Glen Sojo authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9a499b9 View commit details
    Browse the repository at this point in the history

  7. [FIX] - document-page-approval: Fixes OCA#60 url not valid when websi… 

    …te module is installed.
    @victoralmau
    Glen Sojo authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    1497f2d View commit details
    Browse the repository at this point in the history

  8. [MIG] document_page_approval: Migration to 9.0 

    * Lint error corrected
* test improved
* lint error corrected in test file
* readme corrected
* test improved
* test of document page history workflow added
* CI error corrected
* dreipst comment
* Migration to new api improved in model's file and data tag remove in xml file
* code totally migrate to odoo 9.0 api
* test bug fixed
* test error fixed
* Lint error improved
    @naousse @victoralmau
    naousse authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    7c74b68 View commit details
    Browse the repository at this point in the history

  9. [MIG] document_page_approval: Migration to 10.0

    @LeartS @victoralmau
    LeartS authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c5fea1f View commit details
    Browse the repository at this point in the history

  10. [FIX] View

    @max3903 @victoralmau
    max3903 authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a7a1424 View commit details
    Browse the repository at this point in the history

  11. [IMP][10.0][document_page_approval] Change Requests and workflow impr… 

    …ovements on documents (OCA#155)
    @ivantodorovich @victoralmau
    ivantodorovich authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c3bb2e0 View commit details
    Browse the repository at this point in the history

  12. [MIG] document_page_approval: Migration to 11.0

    @victoralmau
    Gabriela Mogollon authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    99bace0 View commit details
    Browse the repository at this point in the history

  13. [FIX+IMP] document_page_approval: 

    * Rename classes and files to match model names, and removed workflow engine.
* Some fields should be readonly if not in draft.
* Allow Knowledge / Manager to edit previous history names and summary
* Improve ux by adding user_has_drafts to document pages.
* Changes because of implementation of active field on document_page
* Add ir.rules for document.page.history
* Allow to quickly cancel&draft from 'to approve' state
* FIX BUG: am_i_approver was being run as sudo(), hence always giving the user Approving rights.
* FIX hooks
  Because of default='draft' on the state field, state IS NULL wasn't selecting anything.
  Left the condition in case this is changed in the future.
    @ivantodorovich @victoralmau
    ivantodorovich authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    0915ea6 View commit details
    Browse the repository at this point in the history

  14. [FIX] pylint/javascript-lint 

    [ADD] icon.png
    @MiquelRForgeFlow @victoralmau
    MiquelRForgeFlow authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a0910c6 View commit details
    Browse the repository at this point in the history

  15. [FIX] document_page_aproval: Modify in records rules 

     Add the the group eployee to the rule "Change Request Global" to allow to the user with the rule "Change Request Approver" to create pages
    @nicomacr @victoralmau
    nicomacr authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3c038cf View commit details
    Browse the repository at this point in the history

  16. [MIG] document_page_approval: Migration to v12 

    [UPD] Update document_page_approval.pot
    @victoralmau
    Victor M.M. Torres authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b885671 View commit details
    Browse the repository at this point in the history

  17. [IMP] document_page_approval: black, isort

    @victoralmau
    flachica authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b2653fc View commit details
    Browse the repository at this point in the history

  18. Migrate to 13.0 document_page_approval 

    To pass test is necesary set approval required to False in demo data
    @victoralmau
    flachica authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    4257dd7 View commit details
    Browse the repository at this point in the history

  19. [IMP] document_page_approval: black, isort, prettier + squashed admin… 

    … commits
    @jeroen-vet @victoralmau
    jeroen-vet authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    af56fba View commit details
    Browse the repository at this point in the history

  20. [MIG] document_page_approval: Migration to 14.0 

    [UPD] Update document_page_approval.pot

[UPD] README.rst
    @jeroen-vet @victoralmau
    jeroen-vet authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    0db8877 View commit details
    Browse the repository at this point in the history

  21. [FIX] document_page_approval: Avoid W7940 (dangerous-view-replace-wo-… 

    …priority)
    @pedrobaeza @victoralmau
    pedrobaeza authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    21c3bab View commit details
    Browse the repository at this point in the history

  22. [MIG] document_page_approval: Migration to 15.0 

    TT36950

[UPD] Update document_page_approval.pot

[UPD] README.rst
    @victoralmau
    victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9a203c4 View commit details
    Browse the repository at this point in the history

  23. [16.0][MIG] document_page_approval: Migration to 16.0 

    [UPD] Update document_page_approval.pot

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/
    @FernandoRomera @victoralmau
    FernandoRomera authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    855ada5 View commit details
    Browse the repository at this point in the history

  24. Translated using Weblate (Italian) 

    Currently translated at 100.0% (61 of 61 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/

Translated using Weblate (Italian)

Currently translated at 100.0% (61 of 61 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/
    @mymage @victoralmau
    mymage authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a8534ab View commit details
    Browse the repository at this point in the history

  25. Translated using Weblate (Croatian) 

    Currently translated at 83.6% (51 of 61 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/hr/

Translated using Weblate (Croatian)

Currently translated at 96.7% (59 of 61 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/hr/
    @badbole @victoralmau
    badbole authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    1138d05 View commit details
    Browse the repository at this point in the history

  26. Translated using Weblate (Italian) 

    Currently translated at 100.0% (61 of 61 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/
    @francesco-ooops @victoralmau
    francesco-ooops authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    37b8da5 View commit details
    Browse the repository at this point in the history

  27. Translated using Weblate (Italian) 

    Currently translated at 100.0% (61 of 61 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/
    @mymage @victoralmau
    mymage authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a91aeb6 View commit details
    Browse the repository at this point in the history

  28. [FIX] document_page_approval: Change mail template expressions 

    [UPD] Update document_page_approval.pot

document_page_approval 16.0.1.1.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/
    @victoralmau
    victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    012c735 View commit details
    Browse the repository at this point in the history

  29. Translated using Weblate (Italian) 

    Currently translated at 96.7% (59 of 61 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/

Translated using Weblate (Italian)

Currently translated at 96.7% (59 of 61 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/

[UPD] Update document_page_approval.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/
    @francesco-ooops @victoralmau
    francesco-ooops authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    77c573c View commit details
    Browse the repository at this point in the history

  30. Translated using Weblate (Italian) 

    Currently translated at 96.7% (59 of 61 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/
    @mymage @victoralmau
    mymage authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    06e5f42 View commit details
    Browse the repository at this point in the history

  31. Translated using Weblate (Spanish) 

    Currently translated at 95.0% (58 of 61 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/es/
    @luis-ron @victoralmau
    luis-ron authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    4ea8772 View commit details
    Browse the repository at this point in the history

  32. Translated using Weblate (Italian) 

    Currently translated at 96.7% (59 of 61 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/
    @francesco-ooops @victoralmau
    francesco-ooops authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    70e9353 View commit details
    Browse the repository at this point in the history

  33. Translated using Weblate (Italian) 

    Currently translated at 100.0% (61 of 61 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/
    @mymage @victoralmau
    mymage authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c4fe172 View commit details
    Browse the repository at this point in the history

  34. Translated using Weblate (Spanish) 

    Currently translated at 100.0% (61 of 61 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/es/

[UPD] Update document_page_approval.pot

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/
    @Ivorra78 @victoralmau
    Ivorra78 authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    41b2029 View commit details
    Browse the repository at this point in the history

  35. Translated using Weblate (Italian) 

    Currently translated at 100.0% (61 of 61 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/
    @mymage @victoralmau
    mymage authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    48c055e View commit details
    Browse the repository at this point in the history

  36. Translated using Weblate (Spanish) 

    Currently translated at 100.0% (61 of 61 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/es/

[UPD] Update document_page_approval.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/
    @Ivorra78 @victoralmau
    Ivorra78 authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    be906f7 View commit details
    Browse the repository at this point in the history

  37. Translated using Weblate (Portuguese) 

    Currently translated at 100.0% (60 of 60 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/pt/

[UPD] Update document_page_approval.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/
    @peterromao @victoralmau
    peterromao authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    d426437 View commit details
    Browse the repository at this point in the history

  38. Translated using Weblate (Italian) 

    Currently translated at 100.0% (62 of 62 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/
    @mymage @victoralmau
    mymage authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    89bf406 View commit details
    Browse the repository at this point in the history

  39. [FIX] document_page_approval: Add correct followers in history pages 

    [BOT] post-merge updates
    @victoralmau
    victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    91564a5 View commit details
    Browse the repository at this point in the history

  40. Translated using Weblate (Spanish) 

    Currently translated at 100.0% (62 of 62 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/es/
    @berisoft-arg @victoralmau
    berisoft-arg authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    41da8c7 View commit details
    Browse the repository at this point in the history

  41. Translated using Weblate (Swedish) 

    Currently translated at 100.0% (62 of 62 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_approval
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/sv/
    @jakobkrabbe @victoralmau
    jakobkrabbe authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9684a7a View commit details
    Browse the repository at this point in the history

  42. [IMP] document_page_approval: pre-commit auto fixes

    @victoralmau
    victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b919f6b View commit details
    Browse the repository at this point in the history

  43. [MIG] document_page_approval: Migration to 17.0

    @EdgarRetes @victoralmau
    EdgarRetes authored and victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    74660f1 View commit details
    Browse the repository at this point in the history

  44. [MIG] document_page_approval: Finish migration 

    Changes done:
- Squash administrative commits
- Purge translations
- Remove ir.model.access.csv file
- Improve tests (change to setUpClass)
- Replace name_get() to _compute_display_name() (document_page)
- Remove readonly=1 (redudant, it already is) defined in approved_uid and approved_date fields in views
- Restore readonly=1 to the state field
- Remove duplicate Back to draft button

TT51529
    @victoralmau
    victoralmau committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    6438cd2 View commit details
    Browse the repository at this point in the history