Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NCBO BioPortal link #2654

Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat: add NCBO BioPortal link #2654

merged 1 commit into from
Nov 25, 2024

Conversation

jsstevenson
Copy link
Contributor

@jsstevenson jsstevenson commented Nov 25, 2024

address #80 ? I didn't read the rest of the conversation, not sure if there's more work to be done there outside of this.

  • Add button to link to corresponding NCBO BioPortal page
  • Update other browser links to proper external links
  • Special cases are all hard coded rather than figuring out a regex. It's implemented as a custom liquid plugin, should be fairly easy to update if necessary.

@jsstevenson jsstevenson requested a review from matentzn November 25, 2024 14:51
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it works this looks greeeat!!! THANKS!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boom.

@jsstevenson jsstevenson merged commit b6c78bc into master Nov 25, 2024
5 checks passed
@jsstevenson jsstevenson deleted the jss/bioportal branch November 25, 2024 15:54
@matentzn
Copy link
Contributor

matentzn commented Nov 25, 2024

@jsstevenson somehow the BioPortal links are lowercased on the site?
https://obofoundry.org/ontology/mondo.html

@jsstevenson
Copy link
Contributor Author

@matentzn ...bizarre. This was working locally. Give me a minute

@jsstevenson
Copy link
Contributor Author

Oh, right, the way we're deploying the Jekyll site won't support custom liquid plugins. I'll need to do a quick fix

@nataled
Copy link
Contributor

nataled commented Nov 25, 2024

PRO already had a working BioPortal link. There are now two (the second, new link, is non-working).

@jsstevenson
Copy link
Contributor Author

jsstevenson commented Nov 25, 2024

Alright, sorry about that. Fix for both is in #2655. This was working locally (although I missed the extra browser links for PRO et al) but GitHub's native jekyll deployment places some limits on the kinds of plugins you can add yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants