Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cannonical name for CNAME content field #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JRaver
Copy link

@JRaver JRaver commented Dec 15, 2022

In record type CNAME you should always add additional dot, added possibility use like in name field

Copy link

@frankmit11 frankmit11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Thank you!

@frankmit11
Copy link

I use this ansible module a lot to interact with powerDNS, it is very handy, for the longest time I couldn't figure out why the code kept failing when trying to add CNAME records. This is the fix and needs to be merged into master. I'm not sure who is still in charge of this repo or who has write permissions....but I copied this updated code, ran it in my environment, works like a charm 👍

@Nosmoht
Copy link
Owner

Nosmoht commented Jul 3, 2024

Hi @frankmit11,

sorry for the late answer. I'm happy to merge your PR if you could please fix the merge conflicts.

@frankmit11
Copy link

frankmit11 commented Jul 3, 2024

Hello @Nosmoht,

Thanks for the reply, so this is not my PR, I'm just someone benefiting from the added support. Looks like @JRaver is trying to merge in his forked changes, so perhaps he can help. If not I can resolve the merge conflicts myself and open another PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants