Replace sprintf with snprintf due to macOS deprecation

sprintf is deprecated due to security concerns. Using snprintf(3) instead to avoid warnings (-Wdeprecated-declarations). Signed-off-by: Björn Svensson <[email protected]>
Nordix · Dec 5, 2024 · c38228f · c38228f
1 parent 45127b4
commit c38228f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/src/lib/data_mgr/ByteString.cpp b/src/lib/data_mgr/ByteString.cpp
@@ -227,8 +227,7 @@ std::string ByteString::hex_str() const
 
 	for (size_t i = 0; i < byteString.size(); i++)
 	{
-		sprintf(hex, "%02X", byteString[i]);
-
+		snprintf(hex, sizeof(hex), "%02X", byteString[i]);
 		rv += hex;
 	}
 

diff --git a/src/lib/handle_mgr/test/handlemgrtest.cpp b/src/lib/handle_mgr/test/handlemgrtest.cpp
@@ -89,7 +89,7 @@ class MyProgressListener : public CppUnit::TextTestProgressListener
 private:
 	std::string TimeFormat(double time) {
 		char buffer[320];
-		::sprintf(buffer, "%6f", time);
+		snprintf(buffer, sizeof(buffer), "%6f", time);
 		return buffer;
 	}
 

diff --git a/src/lib/object_store/UUID.cpp b/src/lib/object_store/UUID.cpp
@@ -55,10 +55,10 @@ std::string UUID::newUUID()
 
 	// Convert it to a string
 	char uuidStr[37];
-
-	sprintf(uuidStr, "%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-%02x%02x%02x%02x%02x%02x",
-		uuid[0], uuid[1], uuid[2], uuid[3], 
-		uuid[4], uuid[5], 
+	snprintf(uuidStr, sizeof(uuidStr),
+		"%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-%02x%02x%02x%02x%02x%02x",
+		uuid[0], uuid[1], uuid[2], uuid[3],
+		uuid[4], uuid[5],
 		uuid[6], uuid[7],
 		uuid[8], uuid[9],
 		uuid[10], uuid[11], uuid[12], uuid[13], uuid[14], uuid[15]);